linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + mmc-sd-clean-up-redundant-memset.patch added to -mm tree
@ 2010-04-13 19:50 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-04-13 19:50 UTC (permalink / raw)
  To: mm-commits; +Cc: asselsm, linux-mmc


The patch titled
     mmc: sd: clean up redundant memset
has been added to the -mm tree.  Its filename is
     mmc-sd-clean-up-redundant-memset.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: mmc: sd: clean up redundant memset
From: Mark Asselstine <asselsm@gmail.com>

The clearing of mrq via a memset at the top of the for loop in
mmc_wait_for_app_cmd() is not required as mrq is not used and there is
another clearing of mrq just below.  We remove the first memset since if
the initial tests in the for loop fail the memset is not required.

Signed-off-by: Mark Asselstine <asselsm@gmail.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/mmc/core/sd_ops.c |    2 --
 1 file changed, 2 deletions(-)

diff -puN drivers/mmc/core/sd_ops.c~mmc-sd-clean-up-redundant-memset drivers/mmc/core/sd_ops.c
--- a/drivers/mmc/core/sd_ops.c~mmc-sd-clean-up-redundant-memset
+++ a/drivers/mmc/core/sd_ops.c
@@ -79,8 +79,6 @@ int mmc_wait_for_app_cmd(struct mmc_host
 	 * we cannot use the retries field in mmc_command.
 	 */
 	for (i = 0;i <= retries;i++) {
-		memset(&mrq, 0, sizeof(struct mmc_request));

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-04-13 19:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-13 19:50 + mmc-sd-clean-up-redundant-memset.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).