From: Anton Vorontsov <avorontsov@mvista.com>
To: "Andrew Morton" <akpm@linux-foundation.org>,
"Richard Röjfors" <richard.rojfors@pelagicore.com>
Cc: David Vrabel <david.vrabel@csr.com>,
Pierre Ossman <pierre@ossman.eu>, Ben Dooks <ben@simtec.co.uk>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] sdhci-pltfm: Add kernel-doc for struct sdhci_pltfm_data
Date: Fri, 23 Apr 2010 22:26:19 +0400 [thread overview]
Message-ID: <20100423182619.GA8743@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4BA0732B.7040007@pelagicore.com>
Suggested-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
---
On Wed, Mar 17, 2010 at 07:14:03AM +0100, Richard Röjfors wrote:
> On 3/16/10 7:34 PM, Anton Vorontsov wrote:
> > This includes platform ops, quirks and (de)initialization callbacks.
>
> Good idea, just a doc comment below.
[....]
> > +struct sdhci_pltfm_data {
> > + struct sdhci_ops *ops;
> > + unsigned int quirks;
> > + int (*init)(struct sdhci_host *host);
> > + void (*exit)(struct sdhci_host *host);
> > +};
>
> I would like to see this struct kernel-doc:ed.
Done, thanks!
Andrew,
Please fold this patch into
sdhci-pltfm-implement-platform-data-passing.patch
Thanks,
include/linux/sdhci-pltfm.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/linux/sdhci-pltfm.h b/include/linux/sdhci-pltfm.h
index 0aaa334..0239bd7 100644
--- a/include/linux/sdhci-pltfm.h
+++ b/include/linux/sdhci-pltfm.h
@@ -17,6 +17,14 @@
struct sdhci_ops;
struct sdhci_host;
+/**
+ * struct sdhci_pltfm_data - SDHCI platform-specific information & hooks
+ * @ops: optional pointer to the platform-provided SDHCI ops
+ * @quirks: optional SDHCI quirks
+ * @init: optional hook that is called during device probe, before the
+ * driver tries to access any SDHCI registers
+ * @exit: optional hook that is called during device removal
+ */
struct sdhci_pltfm_data {
struct sdhci_ops *ops;
unsigned int quirks;
--
1.7.0.5
next prev parent reply other threads:[~2010-04-23 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 18:34 [PATCH resend 0/3] sdhci-pltfm: Few additions and enhancements Anton Vorontsov
2010-03-16 18:34 ` [PATCH 1/3] sdhci: Implement CAP_CLOCK_BASE_BROKEN quirk Anton Vorontsov
2010-03-16 18:34 ` [PATCH 2/3] sdhci-pltfm: Implement platform data passing Anton Vorontsov
2010-03-17 6:14 ` Richard Röjfors
2010-04-23 18:26 ` Anton Vorontsov [this message]
2010-03-16 18:34 ` [PATCH 3/3] sdhci-pltfm: Do not print errors in case of an extended iomem size Anton Vorontsov
2010-03-17 6:02 ` Richard Röjfors
2010-03-22 19:30 ` Andrew Morton
2010-04-23 18:25 ` Anton Vorontsov
2010-05-03 6:01 ` Richard Röjfors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423182619.GA8743@oksana.dev.rtsoft.ru \
--to=avorontsov@mvista.com \
--cc=akpm@linux-foundation.org \
--cc=ben@simtec.co.uk \
--cc=david.vrabel@csr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pierre@ossman.eu \
--cc=richard.rojfors@pelagicore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).