From: Wolfram Sang <w.sang@pengutronix.de>
To: Matt Fleming <matt@console-pimps.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mmc@vger.kernel.org,
Anton Vorontsov <cbouatmailru@gmail.com>
Subject: Re: [PATCH] sdhci: Rename SDHCI I/O accessor functions
Date: Tue, 27 Apr 2010 08:36:13 +0200 [thread overview]
Message-ID: <20100427063613.GA22743@pengutronix.de> (raw)
In-Reply-To: <a2d0197b810b93814fe3ab8aa78fb0e721b9f08e.1272347885.git.matt@console-pimps.org>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
On Tue, Apr 27, 2010 at 07:01:27AM +0100, Matt Fleming wrote:
> Unfortunately some architectures #define their read{b,w,l} and
> write{b,w,l} I/O accessors which makes the SDHCI I/O accessor functions
> of the same names subject to preprocessing. This leads to the following
> compiler error,
>
> In file included from drivers/mmc/host/sdhci.c:26:
> drivers/mmc/host/sdhci.h:318:35: error: macro "writel" passed 3 arguments, but takes just 2
>
> Rename the SDHCI I/O functions so that CONFIG_MMC_SDHCI_IO_ACCESSORS can
> be enabled for architectures that implement their read{b,w,l} and
> write{b,w,l} functions with macros.
>
> Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
> Signed-off-by: Matt Fleming <matt@console-pimps.org>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
I remember hitting this problem, too.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-04-27 6:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 6:01 [PATCH] sdhci: Rename SDHCI I/O accessor functions Matt Fleming
2010-04-27 6:36 ` Wolfram Sang [this message]
2010-04-28 0:26 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427063613.GA22743@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=cbouatmailru@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).