From: Andrew Morton <akpm@linux-foundation.org>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Matt Fleming <matt@console-pimps.org>,
zhangfei gao <zhangfei.gao@gmail.com>,
linux-mmc@vger.kernel.org
Subject: Re: mmc: sdhci.h compile error
Date: Thu, 29 Apr 2010 15:28:56 -0700 [thread overview]
Message-ID: <20100429152856.30585944.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100426101704.GB2092@oksana.dev.rtsoft.ru>
On Mon, 26 Apr 2010 14:17:04 +0400
Anton Vorontsov <cbouatmailru@gmail.com> wrote:
> On Sun, Apr 25, 2010 at 11:28:17PM +0100, Matt Fleming wrote:
> > On Wed, 21 Apr 2010 19:43:32 +0800, zhangfei gao <zhangfei.gao@gmail.com> wrote:
> > >
> > > There is compile error when we enable CONFIG_MMC_SDHCI_IO_ACCESSORS,
> > > and include header file #include "sdhci.h"
> > > error: macro "writel" passed 3 arguments, but takes just 2
> > >
> >
> > Interesting...
> >
> > It was Anton Vorontsov that added this code; presumably the code has
> > never been compiled for an ARM board (or any other architecture that
> > #define's their I/O accessors in asm/io.h).
>
> Yep, there wasn't any need for these accessors on other platforms.
>
> > It would be better if all architectures declared their I/O accessors as
> > static inline, but I'm not volunteering to touch all those headers ;-)
> > Renaming the SDHCI ops is definitely the easiest option. Anton, do you
> > have a problem with the attached patch to rename the SDHCI accessor
> > functions?
>
> Looks OK.
>
> Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
> (for -next, I presume)
Why not for 2.6.34?
next prev parent reply other threads:[~2010-04-30 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 11:43 mmc: sdhci.h compile error zhangfei gao
2010-04-25 22:28 ` Matt Fleming
2010-04-26 7:46 ` zhangfei gao
2010-04-26 11:18 ` Matt Fleming
2010-04-27 3:45 ` zhangfei gao
2010-04-27 5:53 ` Matt Fleming
2010-04-27 6:54 ` zhangfei gao
2010-04-26 10:17 ` Anton Vorontsov
2010-04-29 22:28 ` Andrew Morton [this message]
2010-04-30 5:30 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100429152856.30585944.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cbouatmailru@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).