From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: mmc: sdhci.h compile error Date: Thu, 29 Apr 2010 15:28:56 -0700 Message-ID: <20100429152856.30585944.akpm@linux-foundation.org> References: <87zl0rb20u.fsf@linux-g6p1.site> <20100426101704.GB2092@oksana.dev.rtsoft.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:53812 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932688Ab0D3RIc (ORCPT ); Fri, 30 Apr 2010 13:08:32 -0400 In-Reply-To: <20100426101704.GB2092@oksana.dev.rtsoft.ru> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Anton Vorontsov Cc: Matt Fleming , zhangfei gao , linux-mmc@vger.kernel.org On Mon, 26 Apr 2010 14:17:04 +0400 Anton Vorontsov wrote: > On Sun, Apr 25, 2010 at 11:28:17PM +0100, Matt Fleming wrote: > > On Wed, 21 Apr 2010 19:43:32 +0800, zhangfei gao wrote: > > > > > > There is compile error when we enable CONFIG_MMC_SDHCI_IO_ACCESSORS, > > > and include header file #include "sdhci.h" > > > error: macro "writel" passed 3 arguments, but takes just 2 > > > > > > > Interesting... > > > > It was Anton Vorontsov that added this code; presumably the code has > > never been compiled for an ARM board (or any other architecture that > > #define's their I/O accessors in asm/io.h). > > Yep, there wasn't any need for these accessors on other platforms. > > > It would be better if all architectures declared their I/O accessors as > > static inline, but I'm not volunteering to touch all those headers ;-) > > Renaming the SDHCI ops is definitely the easiest option. Anton, do you > > have a problem with the attached patch to rename the SDHCI accessor > > functions? > > Looks OK. > > Acked-by: Anton Vorontsov > (for -next, I presume) Why not for 2.6.34?