linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: cbouatmailru@gmail.com, linux-mmc@vger.kernel.org,
	zgao6@marvell.com, Wolfram Sang <w.sang@pengutronix.de>,
	Ben Dooks <ben-linux@fluff.org>
Subject: Re: + sdhci-rename-sdhci-i-o-accessor-functions.patch added to -mm tree
Date: Fri, 30 Apr 2010 12:33:32 -0700	[thread overview]
Message-ID: <20100430123332.13d75668.akpm@linux-foundation.org> (raw)
In-Reply-To: <871vdxphra.fsf@linux-g6p1.site>

On Fri, 30 Apr 2010 07:38:17 +0100
Matt Fleming <matt@console-pimps.org> wrote:

> On Thu, 29 Apr 2010 15:29:26 -0700, akpm@linux-foundation.org wrote:
> > Subject: sdhci: build fix: rename SDHCI I/O accessor functions
> > From: Matt Fleming <matt@console-pimps.org>
> > 
> > Unfortunately some architectures #define their read{b,w,l} and
> > write{b,w,l} I/O accessors which makes the SDHCI I/O accessor functions of
> > the same names subject to preprocessing.  This leads to the following
> > compiler error,
> > 
> > In file included from drivers/mmc/host/sdhci.c:26:
> > drivers/mmc/host/sdhci.h:318:35: error: macro "writel" passed 3 arguments, but takes just 2
> > 
> > Rename the SDHCI I/O functions so that CONFIG_MMC_SDHCI_IO_ACCESSORS can
> > be enabled for architectures that implement their read{b,w,l} and
> > write{b,w,l} functions with macros.
> > 
> > Signed-off-by: Matt Fleming <matt@console-pimps.org>
> > Cc: Zhangfei Gao <zgao6@marvell.com>
> > Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
> > Cc: <linux-mmc@vger.kernel.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> Hi Andrew,
> 
> this patch got a couple more ACKs from Wolfram Sang and Ben Dooks. Would
> like me to respin the patch?

I updated the changelog text, thanks.

      reply	other threads:[~2010-04-30 19:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-29 22:29 + sdhci-rename-sdhci-i-o-accessor-functions.patch added to -mm tree akpm
2010-04-30  6:38 ` Matt Fleming
2010-04-30 19:33   ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100430123332.13d75668.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ben-linux@fluff.org \
    --cc=cbouatmailru@gmail.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=matt@console-pimps.org \
    --cc=w.sang@pengutronix.de \
    --cc=zgao6@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).