From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH] mmc: drop the "state" argument to mmc_suspend_host() Date: Thu, 13 May 2010 23:11:01 +0400 Message-ID: <20100513191101.GA16241@oksana.dev.rtsoft.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:52942 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754193Ab0EMTLG (ORCPT ); Thu, 13 May 2010 15:11:06 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Matt Fleming Cc: Andrew Morton , Kevin Hilman , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Nicolas Ferre , Manuel Lauss , Cliff Cai , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Pavel Pisa , David Brown , Daniel Walker , Bryan Huntsman , Jarkko Lavinen , Madhusudhan Chikkature , Ben Dooks , Sascha Sommer , Alex Dubov , Ian Molton , Joseph Chan , Harald Welte , Pierre Ossman On Thu, May 13, 2010 at 08:01:45PM +0100, Matt Fleming wrote: > Even though many mmc host drivers pass a pm_message_t argument to > mmc_suspend_host() that argument isn't used the by MMC core. As host > drivers are converted to dev_pm_ops they'll have to construct > pm_message_t's (as they won't be passed by the PM subsystem any more) > just to appease the mmc suspend interface. > > We might as well just delete the unused paramter. > > Signed-off-by: Matt Fleming For sdhci-of* Acked-by: Anton Vorontsov Thanks!