From: Tony Lindgren <tony@atomide.com>
To: kishore kadiyala <kishore.kadiyala@ti.com>
Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
madhu.cr@ti.com, jarkko.lavinen@nokia.com, rmk@arm.linux.org.uk,
paul@pwsan.com, santosh.shilimkar@ti.com
Subject: Re: [PATCH v4 4/5] OMAP HSMMC: Adding a flag to determine the card detect type
Date: Mon, 17 May 2010 19:56:21 -0700 [thread overview]
Message-ID: <20100518025621.GH5818@atomide.com> (raw)
In-Reply-To: <22510.10.24.255.17.1273947712.squirrel@dbdmail.itg.ti.com>
* kishore kadiyala <kishore.kadiyala@ti.com> [100515 11:16]:
> Adding a flag to determine the card detect type which can be
> either GPIO or NON-GPIO.MMC1 Controller of OMAP4 have NON-GPIO
> interrupt line from twl6030 for card detect.
>
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
> ---
> arch/arm/mach-omap2/board-2430sdp.c | 2 ++
> arch/arm/mach-omap2/board-3430sdp.c | 3 +++
> arch/arm/mach-omap2/board-cm-t35.c | 3 +++
> arch/arm/mach-omap2/board-devkit8000.c | 2 ++
> arch/arm/mach-omap2/board-igep0020.c | 3 +++
> arch/arm/mach-omap2/board-ldp.c | 2 ++
> arch/arm/mach-omap2/board-omap3beagle.c | 2 ++
> arch/arm/mach-omap2/board-omap3evm.c | 2 ++
> arch/arm/mach-omap2/board-omap3pandora.c | 4 ++++
> arch/arm/mach-omap2/board-omap3touchbook.c | 2 ++
> arch/arm/mach-omap2/board-overo.c | 3 +++
> arch/arm/mach-omap2/board-rx51-peripherals.c | 3 +++
> arch/arm/mach-omap2/board-zoom-peripherals.c | 3 +++
> arch/arm/mach-omap2/hsmmc.h | 1 +
> arch/arm/plat-omap/include/plat/mmc.h | 4 ++++
> 15 files changed, 39 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
> index a11a575..c7dec0e 100644
> --- a/arch/arm/mach-omap2/board-2430sdp.c
> +++ b/arch/arm/mach-omap2/board-2430sdp.c
> @@ -37,6 +37,7 @@
> #include <plat/gpmc.h>
> #include <plat/usb.h>
> #include <plat/gpmc-smc91x.h>
> +#include <plat/mmc.h>
>
> #include "hsmmc.h"
>
> @@ -196,6 +197,7 @@ static struct omap2_hsmmc_info mmc[] __initdata = {
> .mmc = 1,
> .wires = 4,
> .gpio_cd = -EINVAL,
> + .cd_type = GPIO,
> .gpio_wp = -EINVAL,
> .ext_clock = 1,
> },
To me it seems it would be simpler to just set a flag for the non-gpio
boards instead of patching all of them for gpio. Also, let's see
what we can do with the generic features flag we have now.
Regards,
Tony
prev parent reply other threads:[~2010-05-18 2:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 18:21 [PATCH v4 4/5] OMAP HSMMC: Adding a flag to determine the card detect type kishore kadiyala
2010-05-18 2:56 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518025621.GH5818@atomide.com \
--to=tony@atomide.com \
--cc=jarkko.lavinen@nokia.com \
--cc=kishore.kadiyala@ti.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=paul@pwsan.com \
--cc=rmk@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox