* [patch 008/203] mmc: sd: clean up redundant memset
@ 2010-05-26 21:41 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2010-05-26 21:41 UTC (permalink / raw)
To: torvalds; +Cc: akpm, asselsm, linux-mmc
From: Mark Asselstine <asselsm@gmail.com>
The clearing of mrq via a memset at the top of the for loop in
mmc_wait_for_app_cmd() is not required as mrq is not used and there is
another clearing of mrq just below. We remove the first memset since if
the initial tests in the for loop fail the memset is not required.
Signed-off-by: Mark Asselstine <asselsm@gmail.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/mmc/core/sd_ops.c | 2 --
1 file changed, 2 deletions(-)
diff -puN drivers/mmc/core/sd_ops.c~mmc-sd-clean-up-redundant-memset drivers/mmc/core/sd_ops.c
--- a/drivers/mmc/core/sd_ops.c~mmc-sd-clean-up-redundant-memset
+++ a/drivers/mmc/core/sd_ops.c
@@ -79,8 +79,6 @@ int mmc_wait_for_app_cmd(struct mmc_host
* we cannot use the retries field in mmc_command.
*/
for (i = 0;i <= retries;i++) {
- memset(&mrq, 0, sizeof(struct mmc_request));
-
err = mmc_app_cmd(host, card);
if (err) {
/* no point in retrying; no APP commands allowed */
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-26 21:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 21:41 [patch 008/203] mmc: sd: clean up redundant memset akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox