* [patch 022/203] drivers/mmc/host: use ERR_CAST
@ 2010-05-26 21:42 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2010-05-26 21:42 UTC (permalink / raw)
To: torvalds; +Cc: akpm, julia, linux-mmc
From: Julia Lawall <julia@diku.dk>
Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more
clear what is the purpose of the operation, which otherwise looks like a
no-op.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
type T;
T x;
identifier f;
@@
T f (...) { <+...
- ERR_PTR(PTR_ERR(x))
+ x
...+> }
@@
expression x;
@@
- ERR_PTR(PTR_ERR(x))
+ ERR_CAST(x)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/mmc/host/sdhci-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/mmc/host/sdhci-pci.c~drivers-mmc-host-use-err_cast drivers/mmc/host/sdhci-pci.c
--- a/drivers/mmc/host/sdhci-pci.c~drivers-mmc-host-use-err_cast
+++ a/drivers/mmc/host/sdhci-pci.c
@@ -628,7 +628,7 @@ static struct sdhci_pci_slot * __devinit
host = sdhci_alloc_host(&pdev->dev, sizeof(struct sdhci_pci_slot));
if (IS_ERR(host)) {
dev_err(&pdev->dev, "cannot allocate host\n");
- return ERR_PTR(PTR_ERR(host));
+ return ERR_CAST(host);
}
slot = sdhci_priv(host);
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-26 21:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 21:42 [patch 022/203] drivers/mmc/host: use ERR_CAST akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox