Re: + s5pc110-sdhci-s3c-can-override-host-capabilities.patch added to -mm tree

[Ben Dooks <ben-linux@fluff.org>]

On Fri, Jun 11, 2010 at 12:24:00PM +0900, Kyungmin Park wrote:
> On Fri, Jun 11, 2010 at 9:34 AM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Thu, Jun 10, 2010 at 01:43:14PM -0700, akpm@linux-foundation.org wrote:
> >>
> >> The patch titled
> >>      s5pc110: SDHCI-s3c can override host capabilities
> >> has been added to the -mm tree.  Its filename is
> >>      s5pc110-sdhci-s3c-can-override-host-capabilities.patch
> >>
> >> Before you just go and hit "reply", please:
> >>    a) Consider who else should be cc'ed
> >>    b) Prefer to cc a suitable mailing list as well
> >>    c) Ideally: find the original patch on the mailing list and do a
> >>       reply-to-all to that, adding suitable additional cc's
> >>
> >> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> >>
> >> See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
> >> out what to do about this
> >>
> >> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
> >>
> >> ------------------------------------------------------
> >> Subject: s5pc110: SDHCI-s3c can override host capabilities
> >> From: Kyungmin Park <kmpark@infradead.org>
> >>
> >> Each board can override the default sdhci host capabilities.
> >> Some board has broken features by hardwares and support 8-bit bandwidth.
> >
> > I'd much rather see a mask to remove unsupported features than simply
> > override the already read hardware mask.
> 
> what do you mean? please see the Marek patch, each boards can use its
> own connection and configurations. So there's default caps (it's from
> you) and board can override it for their own purpose.

I'm having a rethink about the whole caps, it may not have been such a good
idea to do that way. Having the .caps fields means that each board that
needs to override it has to know all the caps for the controller meaning
it is much more difficult to share a standard platform data structure
across the system.

Note, for this we already have a max_width field, we could have easily
used that to force the 8bit capability off in the driver too.
 
> Thank you,
> Kyungmin Park
> 
> >
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> Cc: <linux-mmc@vger.kernel.org>
> >> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> >> ---
> >>
> >>  arch/arm/plat-samsung/dev-hsmmc.c  |    2 ++
> >>  arch/arm/plat-samsung/dev-hsmmc1.c |    2 ++
> >>  arch/arm/plat-samsung/dev-hsmmc2.c |    2 ++
> >>  3 files changed, 6 insertions(+)
> >>
> >> diff -puN arch/arm/plat-samsung/dev-hsmmc.c~s5pc110-sdhci-s3c-can-override-host-capabilities arch/arm/plat-samsung/dev-hsmmc.c
> >> --- a/arch/arm/plat-samsung/dev-hsmmc.c~s5pc110-sdhci-s3c-can-override-host-capabilities
> >> +++ a/arch/arm/plat-samsung/dev-hsmmc.c
> >> @@ -65,4 +65,6 @@ void s3c_sdhci0_set_platdata(struct s3c_
> >>               set->cfg_gpio = pd->cfg_gpio;
> >>       if (pd->cfg_card)
> >>               set->cfg_card = pd->cfg_card;
> >> +     if (pd->host_caps)
> >> +             set->host_caps = pd->host_caps;
> >>  }
> >> diff -puN arch/arm/plat-samsung/dev-hsmmc1.c~s5pc110-sdhci-s3c-can-override-host-capabilities arch/arm/plat-samsung/dev-hsmmc1.c
> >> --- a/arch/arm/plat-samsung/dev-hsmmc1.c~s5pc110-sdhci-s3c-can-override-host-capabilities
> >> +++ a/arch/arm/plat-samsung/dev-hsmmc1.c
> >> @@ -65,4 +65,6 @@ void s3c_sdhci1_set_platdata(struct s3c_
> >>               set->cfg_gpio = pd->cfg_gpio;
> >>       if (pd->cfg_card)
> >>               set->cfg_card = pd->cfg_card;
> >> +     if (pd->host_caps)
> >> +             set->host_caps = pd->host_caps;
> >>  }
> >> diff -puN arch/arm/plat-samsung/dev-hsmmc2.c~s5pc110-sdhci-s3c-can-override-host-capabilities arch/arm/plat-samsung/dev-hsmmc2.c
> >> --- a/arch/arm/plat-samsung/dev-hsmmc2.c~s5pc110-sdhci-s3c-can-override-host-capabilities
> >> +++ a/arch/arm/plat-samsung/dev-hsmmc2.c
> >> @@ -66,4 +66,6 @@ void s3c_sdhci2_set_platdata(struct s3c_
> >>               set->cfg_gpio = pd->cfg_gpio;
> >>       if (pd->cfg_card)
> >>               set->cfg_card = pd->cfg_card;
> >> +     if (pd->host_caps)
> >> +             set->host_caps = pd->host_caps;
> >>  }
> >> _
> >>
> >> Patches currently in -mm which might be from kmpark@infradead.org are
> >>
> >> mmc-recognize-csd-structure.patch
> >> mmc-recognize-csd-structure-fix.patch
> >> s5pc110-sdhci-s3c-can-override-host-capabilities.patch
> >> s5pc110-sdhci-s3c-support-on-s5pc110.patch
> >> sdhci-add-no-hi-speed-bit-quirk-support.patch
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> > --
> > --
> > Ben
> >
> > Q:      What's a light-year?
> > A:      One-third less calories than a regular year.
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.