From: Andrew Morton <akpm@linux-foundation.org>
To: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-mmc@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Olof Johansson <olof@lixom.net>, Colin Cross <ccross@android.com>
Subject: Re: [PATCH 2/3] SDHCI: Don't assign mmc->caps at SDHCI directly
Date: Mon, 28 Jun 2010 11:34:15 -0700 [thread overview]
Message-ID: <20100628113415.a36c1348.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100612054450.GA25682@july>
On Sat, 12 Jun 2010 14:44:50 +0900
Kyungmin Park <kyungmin.park@samsung.com> wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Some host controller can set mmc->caps before sdhci_add_host.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/host/sdhci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 4321e0c..142419c 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1791,7 +1791,7 @@ int sdhci_add_host(struct sdhci_host *host)
> else
> mmc->f_min = host->max_clk / 256;
> mmc->f_max = host->max_clk;
> - mmc->caps = MMC_CAP_SDIO_IRQ;
> + mmc->caps |= MMC_CAP_SDIO_IRQ;
>
> if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA))
> mmc->caps |= MMC_CAP_4_BIT_DATA;
A great shower of MMC patches have magically turned up in linux-next,
apparently via some tree of Grant's. Those patches changed the above
code to look like:
if (!(host->quirks & SDHCI_QUIRK_NO_SDIO_IRQ))
mmc->caps |= MMC_CAP_SDIO_IRQ;
So it appears that this bug is fixed in that code as well. So I'll
drop your patch. If the above changes end up not getting merged into
mainline then your fix will be lost.
That fix was unchangelogged. In fact the patch was completely
unchangelogged and I haven't looked at it at all and as far as I can
tell none of it has been sent to the mmc list.
next prev parent reply other threads:[~2010-06-28 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 5:44 [PATCH 2/3] SDHCI: Don't assign mmc->caps at SDHCI directly Kyungmin Park
2010-06-28 18:34 ` Andrew Morton [this message]
2010-06-28 19:35 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628113415.a36c1348.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=grant.likely@secretlab.ca \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox