From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan Date: Fri, 23 Jul 2010 10:15:04 +0100 Message-ID: <20100723091503.GA12300@rakim.wolfsonmicro.main> References: <1279733634-21974-1-git-send-email-ohad@wizery.com> <1279733634-21974-11-git-send-email-ohad@wizery.com> <20100721175930.GD10930@sirena.org.uk> <4C48287D.1000603@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ohad Ben-Cohen Cc: Roger Quadros , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Kalle Valo , Pandita Vikram , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , Nicolas Pitre , Tony Lindgren , San Mehat , Chikkature Rajashekar Madhusudhan , "Coelho Luciano (Nokia-MS/Helsinki)" , "akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-mmc@vger.kernel.org On Fri, Jul 23, 2010 at 02:13:38AM +0300, Ohad Ben-Cohen wrote: > On Thu, Jul 22, 2010 at 2:16 PM, Roger Quadros wrote: > > .dev_name =A0 =A0 =A0 =3D "mmci-omap-hs.2" > I already set the .dev member of the consumer in a similar manner to > how all other regulators are configured in this board - please check > out patch 13: > https://patchwork.kernel.org/patch/113418/ > Does this look reasonable to you ? You should really be using dev_name in preference to dev these days unless there's a *very* good reason. -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html