From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: linux-arm-kernel@lists.infradead.org,
STEricsson_nomadik_linux@list.st.com, linux-mmc@vger.kernel.org,
Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [PATCH 02/12] mmci: fix multi block transfers
Date: Thu, 29 Jul 2010 14:18:58 +0100 [thread overview]
Message-ID: <20100729131858.GB18923@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1277198267-10860-2-git-send-email-rabin.vincent@stericsson.com>
On Tue, Jun 22, 2010 at 02:47:37PM +0530, Rabin Vincent wrote:
> Fix the data transfer size to allow multi block transfers to work.
>
> Acked-by: Linus Walleij <linus.walleij@stericsson.com>
> Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
The first two patches improve performance on Versatile, from 20.5s to
read 1MB down to 18.5s - a 10% improvement.
I was worried that the first patch would add too much overhead, and
cause the hardware to overrun - as the ARM version of these primecells
does not have the capability to stop the clock when the FIFO fills
up, any increase in IRQ latency to read the FIFO will result in an
overrun.
So this is good news. I've applied the first three patches in this
series, but we do need to sort out the card detect situation properly
before continuing.
next prev parent reply other threads:[~2010-07-29 13:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 9:17 [PATCH 01/12] mmci: use sg_miter API to fix multi-page sg handling Rabin Vincent
2010-06-22 9:17 ` [PATCH 02/12] mmci: fix multi block transfers Rabin Vincent
2010-07-29 13:18 ` Russell King - ARM Linux [this message]
2010-06-22 9:17 ` [PATCH 03/12] mmci: let core poll for card detection Rabin Vincent
2010-06-22 9:17 ` [PATCH 04/12] mmci: allow the card detect status not to be inverted Rabin Vincent
2010-07-29 12:34 ` Russell King - ARM Linux
2010-07-29 13:53 ` Linus Walleij
2010-07-29 14:20 ` Russell King - ARM Linux
2010-08-05 6:14 ` Rabin VINCENT
2010-08-05 9:25 ` Russell King - ARM Linux
2010-08-09 10:37 ` Rabin VINCENT
2010-08-09 11:25 ` Russell King - ARM Linux
2010-06-22 9:17 ` [PATCH 05/12] mmci: support card detection interrupts Rabin Vincent
2010-06-22 9:17 ` [PATCH 06/12] mmci: allow neither ->status nor gpio_cd to be specified Rabin Vincent
2010-06-22 9:17 ` [PATCH 07/12] mmci: pass power_mode to the translate_vdd callback Rabin Vincent
2010-06-22 22:03 ` Linus Walleij
2010-06-24 8:27 ` Rabin VINCENT
2010-06-24 8:56 ` Linus WALLEIJ
2010-07-19 12:57 ` [PATCHv2 " Rabin Vincent
2010-06-22 9:17 ` [PATCH 08/12] mmci: add variant data and default MCICLOCK support Rabin Vincent
2010-06-22 9:17 ` [PATCH 09/12] mmci: enable hardware flow control on Ux500 variants Rabin Vincent
2010-06-22 9:17 ` [PATCH 10/12] mmci: support larger MMCIDATALENGTH register Rabin Vincent
2010-06-22 9:17 ` [PATCH 11/12] mmci: support different FIFO sizes Rabin Vincent
2010-06-22 9:17 ` [PATCH 12/12] mmci: support variants with only one irq Rabin Vincent
2010-09-23 20:04 ` Linus Walleij
2010-07-07 20:34 ` [PATCH 01/12] mmci: use sg_miter API to fix multi-page sg handling Linus Walleij
2010-07-19 13:23 ` [PATCHv2 " Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729131858.GB18923@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rabin.vincent@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).