'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

[Kukjin Kim]

Hi, 

This is just information about Samsung sdmmc stuff building error now.

I found Marek's 'sdhci-s3c: enable SDHCI_QUIRK_NO_HISPD_BIT quirk' in the
Linus' tree.
(commit ID: a1d5646005af1247d6ae78434bb4db15b07a07b2)

But not defined the quirk yet...so following build error happened with
s3c6400_defconfig in Linus' latest.

drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe':
drivers/mmc/host/sdhci-s3c.c:400: error: 'SDHCI_QUIRK_NO_HISPD_BIT'
undeclared (first use in this function)
drivers/mmc/host/sdhci-s3c.c:400: error: (Each undeclared identifier is
reported only once
drivers/mmc/host/sdhci-s3c.c:400: error: for each function it appears in.)
make[4]: *** [drivers/mmc/host/sdhci-s3c.o] Error 1
make[3]: *** [drivers/mmc/host] Error 2
make[2]: *** [drivers/mmc] Error 2
make[1]: *** [drivers] Error 2

Kyungmin Park's below patch can solve this and it is in mmotm now.
(commit ID: 2935b9e7fcc4bea3751b8d039b383b2036a7d36d)

But I think, to update quirk definition should being in Marek's patch for
avoiding build error.
Of course, I'm not sure whether the commit order changed.
Anyway, in this case, will be solved after merging mm tree.


And second case is same.

Marek's 'sdhci-s3c: add support for new card detection methods' cause
following build error.
(commit ID:17866e14f3a4f219e94f1374ece7226479418ff8)

drivers/built-in.o: In function `sdhci_s3c_notify_change':
/home/kgene/linux/linux-2.6-mainline-dev/drivers/mmc/host/sdhci-s3c.c:255:
undefined reference to `sdhci_card_detect'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [sub-make] Error 2

And Andrew's patch(b567e5dd5a34c184e5642100e752cb87e064bb97) can solve this.
(of course this needs another patches...)

Anyway...
Marek, in future please make sure your patch has no building problem before
submitting.
(or it can help to add some kind of dependency note in your patch)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

RE: 'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

[Marek Szyprowski]

Hello,

On Friday, August 13, 2010 9:32 AM Kukjin Kim wrote:

> This is just information about Samsung sdmmc stuff building error now.
> 
> I found Marek's 'sdhci-s3c: enable SDHCI_QUIRK_NO_HISPD_BIT quirk' in the
> Linus' tree.
> (commit ID: a1d5646005af1247d6ae78434bb4db15b07a07b2)
> 
> But not defined the quirk yet...so following build error happened with
> s3c6400_defconfig in Linus' latest.
> 
> drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe':
> drivers/mmc/host/sdhci-s3c.c:400: error: 'SDHCI_QUIRK_NO_HISPD_BIT'
> undeclared (first use in this function)
> drivers/mmc/host/sdhci-s3c.c:400: error: (Each undeclared identifier is
> reported only once
> drivers/mmc/host/sdhci-s3c.c:400: error: for each function it appears in.)
> make[4]: *** [drivers/mmc/host/sdhci-s3c.o] Error 1
> make[3]: *** [drivers/mmc/host] Error 2
> make[2]: *** [drivers/mmc] Error 2
> make[1]: *** [drivers] Error 2
> 
> Kyungmin Park's below patch can solve this and it is in mmotm now.
> (commit ID: 2935b9e7fcc4bea3751b8d039b383b2036a7d36d)
> 
> But I think, to update quirk definition should being in Marek's patch for
> avoiding build error.
> Of course, I'm not sure whether the commit order changed.
> Anyway, in this case, will be solved after merging mm tree.
> 
> 
> And second case is same.
> 
> Marek's 'sdhci-s3c: add support for new card detection methods' cause
> following build error.
> (commit ID:17866e14f3a4f219e94f1374ece7226479418ff8)
> 
> drivers/built-in.o: In function `sdhci_s3c_notify_change':
> /home/kgene/linux/linux-2.6-mainline-dev/drivers/mmc/host/sdhci-s3c.c:255:
> undefined reference to `sdhci_card_detect'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
> 
> And Andrew's patch(b567e5dd5a34c184e5642100e752cb87e064bb97) can solve this.
> (of course this needs another patches...)
> 
> Anyway...
> Marek, in future please make sure your patch has no building problem before
> submitting.
> (or it can help to add some kind of dependency note in your patch)

My patches submited to Andrew Morton had the description and a note that they
have been prepared especially for his tree, taking into account all patches
that are already there (mainly a tasklets to threaded irq conversion). For me
it was quite obvious that they will be merged after all other sdhci changes
from that tree. I have no idea why the order of the patches has been reversed
and my sdhci patches has been submitted to Linus before the other sdhci
changes.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

RE: 'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

[Kukjin Kim]

Marek Szyprowski wrote:
> 
> Hello,
> 
Hi Marek :-)

> On Friday, August 13, 2010 9:32 AM Kukjin Kim wrote:
> 
> > This is just information about Samsung sdmmc stuff building error now.
> >
> > I found Marek's 'sdhci-s3c: enable SDHCI_QUIRK_NO_HISPD_BIT quirk' in
the
> > Linus' tree.
> > (commit ID: a1d5646005af1247d6ae78434bb4db15b07a07b2)
> >
> > But not defined the quirk yet...so following build error happened with
> > s3c6400_defconfig in Linus' latest.
> >
> > drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe':
> > drivers/mmc/host/sdhci-s3c.c:400: error: 'SDHCI_QUIRK_NO_HISPD_BIT'
> > undeclared (first use in this function)
> > drivers/mmc/host/sdhci-s3c.c:400: error: (Each undeclared identifier is
> > reported only once
> > drivers/mmc/host/sdhci-s3c.c:400: error: for each function it appears
in.)
> > make[4]: *** [drivers/mmc/host/sdhci-s3c.o] Error 1
> > make[3]: *** [drivers/mmc/host] Error 2
> > make[2]: *** [drivers/mmc] Error 2
> > make[1]: *** [drivers] Error 2
> >
> > Kyungmin Park's below patch can solve this and it is in mmotm now.
> > (commit ID: 2935b9e7fcc4bea3751b8d039b383b2036a7d36d)
> >
> > But I think, to update quirk definition should being in Marek's patch
for
> > avoiding build error.
> > Of course, I'm not sure whether the commit order changed.
> > Anyway, in this case, will be solved after merging mm tree.
> >
Hmm...not merged yet :-( so happened build error at 36-rc1.

> >
> > And second case is same.
> >
> > Marek's 'sdhci-s3c: add support for new card detection methods' cause
> > following build error.
> > (commit ID:17866e14f3a4f219e94f1374ece7226479418ff8)
> >
> > drivers/built-in.o: In function `sdhci_s3c_notify_change':
> >
/home/kgene/linux/linux-2.6-mainline-dev/drivers/mmc/host/sdhci-s3c.c:255:
> > undefined reference to `sdhci_card_detect'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > make: *** [sub-make] Error 2
> >
> > And Andrew's patch(b567e5dd5a34c184e5642100e752cb87e064bb97) can solve
> this.
> > (of course this needs another patches...)
> >
Same...


This is just information...

The build error of drivers/mmc/host/sdhci-s3c.c can be disappeared with the
Kyungmin's commit 2935b9e7fcc4bea3751b8d039b383b2036a7d36d and Andrew's
commit b567e5dd5a34c184e5642100e752cb87e064bb97 which are in mm tree now.

And will be merged soon...Andrew, right?

> > Anyway...
> > Marek, in future please make sure your patch has no building problem
before
> > submitting.
> > (or it can help to add some kind of dependency note in your patch)
> 
> My patches submited to Andrew Morton had the description and a note that
they
> have been prepared especially for his tree, taking into account all
patches
> that are already there (mainly a tasklets to threaded irq conversion). For
me
> it was quite obvious that they will be merged after all other sdhci
changes
> from that tree. I have no idea why the order of the patches has been
reversed
> and my sdhci patches has been submitted to Linus before the other sdhci
> changes.
> 
> Best regards
> --
> Marek Szyprowski
> Samsung Poland R&D Center


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Re: 'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

[Andrew Morton]

On Fri, 13 Aug 2010 10:13:04 +0200
Marek Szyprowski <m.szyprowski@samsung.com> wrote:

> Hello,
> 
> On Friday, August 13, 2010 9:32 AM Kukjin Kim wrote:
> 
> > This is just information about Samsung sdmmc stuff building error now.
> > 
> > I found Marek's 'sdhci-s3c: enable SDHCI_QUIRK_NO_HISPD_BIT quirk' in the
> > Linus' tree.
> > (commit ID: a1d5646005af1247d6ae78434bb4db15b07a07b2)
> > 
> > But not defined the quirk yet...so following build error happened with
> > s3c6400_defconfig in Linus' latest.
> > 
> > drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe':
> > drivers/mmc/host/sdhci-s3c.c:400: error: 'SDHCI_QUIRK_NO_HISPD_BIT'
> > undeclared (first use in this function)
> > drivers/mmc/host/sdhci-s3c.c:400: error: (Each undeclared identifier is
> > reported only once
> > drivers/mmc/host/sdhci-s3c.c:400: error: for each function it appears in.)
> > make[4]: *** [drivers/mmc/host/sdhci-s3c.o] Error 1
> > make[3]: *** [drivers/mmc/host] Error 2
> > make[2]: *** [drivers/mmc] Error 2
> > make[1]: *** [drivers] Error 2
> > 
> > Kyungmin Park's below patch can solve this and it is in mmotm now.
> > (commit ID: 2935b9e7fcc4bea3751b8d039b383b2036a7d36d)
> > 
> > But I think, to update quirk definition should being in Marek's patch for
> > avoiding build error.
> > Of course, I'm not sure whether the commit order changed.
> > Anyway, in this case, will be solved after merging mm tree.
> > 
> > 
> > And second case is same.
> > 
> > Marek's 'sdhci-s3c: add support for new card detection methods' cause
> > following build error.
> > (commit ID:17866e14f3a4f219e94f1374ece7226479418ff8)
> > 
> > drivers/built-in.o: In function `sdhci_s3c_notify_change':
> > /home/kgene/linux/linux-2.6-mainline-dev/drivers/mmc/host/sdhci-s3c.c:255:
> > undefined reference to `sdhci_card_detect'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > make: *** [sub-make] Error 2
> > 
> > And Andrew's patch(b567e5dd5a34c184e5642100e752cb87e064bb97) can solve this.
> > (of course this needs another patches...)
> > 
> > Anyway...
> > Marek, in future please make sure your patch has no building problem before
> > submitting.
> > (or it can help to add some kind of dependency note in your patch)
> 
> My patches submited to Andrew Morton had the description and a note that they
> have been prepared especially for his tree, taking into account all patches
> that are already there (mainly a tasklets to threaded irq conversion). For me
> it was quite obvious that they will be merged after all other sdhci changes
> from that tree. I have no idea why the order of the patches has been reversed
> and my sdhci patches has been submitted to Linus before the other sdhci
> changes.

We're talking about these:

s5pc110-sdhci-s3c-can-override-host-capabilities.patch
s5pc110-sdhci-s3c-support-on-s5pc110.patch
sdhci-add-no-hi-speed-bit-quirk-support.patch

I have a note that these await an ack from Ben Dooks so I held them
back for a closer look after -rc1.  I was unaware of this dependency.

Ben, are you OK with those patches?

http://userweb.kernel.org/~akpm/mmotm/broken-out/s5pc110-sdhci-s3c-can-override-host-capabilities.patch
http://userweb.kernel.org/~akpm/mmotm/broken-out/s5pc110-sdhci-s3c-support-on-s5pc110.patch
http://userweb.kernel.org/~akpm/mmotm/broken-out/sdhci-add-no-hi-speed-bit-quirk-support.patch

Thanks.

Re: 'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

[Kyungmin Park]

On Thu, Aug 19, 2010 at 3:33 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Fri, 13 Aug 2010 10:13:04 +0200
> Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
>> Hello,
>>
>> On Friday, August 13, 2010 9:32 AM Kukjin Kim wrote:
>>
>> > This is just information about Samsung sdmmc stuff building error now.
>> >
>> > I found Marek's 'sdhci-s3c: enable SDHCI_QUIRK_NO_HISPD_BIT quirk' in the
>> > Linus' tree.
>> > (commit ID: a1d5646005af1247d6ae78434bb4db15b07a07b2)
>> >
>> > But not defined the quirk yet...so following build error happened with
>> > s3c6400_defconfig in Linus' latest.
>> >
>> > drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe':
>> > drivers/mmc/host/sdhci-s3c.c:400: error: 'SDHCI_QUIRK_NO_HISPD_BIT'
>> > undeclared (first use in this function)
>> > drivers/mmc/host/sdhci-s3c.c:400: error: (Each undeclared identifier is
>> > reported only once
>> > drivers/mmc/host/sdhci-s3c.c:400: error: for each function it appears in.)
>> > make[4]: *** [drivers/mmc/host/sdhci-s3c.o] Error 1
>> > make[3]: *** [drivers/mmc/host] Error 2
>> > make[2]: *** [drivers/mmc] Error 2
>> > make[1]: *** [drivers] Error 2
>> >
>> > Kyungmin Park's below patch can solve this and it is in mmotm now.
>> > (commit ID: 2935b9e7fcc4bea3751b8d039b383b2036a7d36d)
>> >
>> > But I think, to update quirk definition should being in Marek's patch for
>> > avoiding build error.
>> > Of course, I'm not sure whether the commit order changed.
>> > Anyway, in this case, will be solved after merging mm tree.
>> >
>> >
>> > And second case is same.
>> >
>> > Marek's 'sdhci-s3c: add support for new card detection methods' cause
>> > following build error.
>> > (commit ID:17866e14f3a4f219e94f1374ece7226479418ff8)
>> >
>> > drivers/built-in.o: In function `sdhci_s3c_notify_change':
>> > /home/kgene/linux/linux-2.6-mainline-dev/drivers/mmc/host/sdhci-s3c.c:255:
>> > undefined reference to `sdhci_card_detect'
>> > make[1]: *** [.tmp_vmlinux1] Error 1
>> > make: *** [sub-make] Error 2
>> >
>> > And Andrew's patch(b567e5dd5a34c184e5642100e752cb87e064bb97) can solve this.
>> > (of course this needs another patches...)
>> >
>> > Anyway...
>> > Marek, in future please make sure your patch has no building problem before
>> > submitting.
>> > (or it can help to add some kind of dependency note in your patch)
>>
>> My patches submited to Andrew Morton had the description and a note that they
>> have been prepared especially for his tree, taking into account all patches
>> that are already there (mainly a tasklets to threaded irq conversion). For me
>> it was quite obvious that they will be merged after all other sdhci changes
>> from that tree. I have no idea why the order of the patches has been reversed
>> and my sdhci patches has been submitted to Linus before the other sdhci
>> changes.
>
> We're talking about these:
>
> s5pc110-sdhci-s3c-can-override-host-capabilities.patch
> s5pc110-sdhci-s3c-support-on-s5pc110.patch
> sdhci-add-no-hi-speed-bit-quirk-support.patch
>
> I have a note that these await an ack from Ben Dooks so I held them
> back for a closer look after -rc1.  I was unaware of this dependency.
>
> Ben, are you OK with those patches?

These are required for support s5pc110 & s5pc210.

Current sdhci on s5p has some wrong assumption. only support 4-bit
bandwidth. and don't consider the embedded mmc like eMMC.

>
> http://userweb.kernel.org/~akpm/mmotm/broken-out/s5pc110-sdhci-s3c-can-override-host-capabilities.patch
It required for override the host caps and pass to the mmc with correct caps
> http://userweb.kernel.org/~akpm/mmotm/broken-out/s5pc110-sdhci-s3c-support-on-s5pc110.patch
required for support s5pc110 and also s5pc210
> http://userweb.kernel.org/~akpm/mmotm/broken-out/sdhci-add-no-hi-speed-bit-quirk-support.patch
As SDHCI on s5p don't has HISPD bit in controller register. need to quirks.
>
> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: 'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

[Kyungmin Park]

On Thu, Aug 19, 2010 at 10:10 AM, Kyungmin Park <kmpark@infradead.org> wrote:
> On Thu, Aug 19, 2010 at 3:33 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>> On Fri, 13 Aug 2010 10:13:04 +0200
>> Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>>
>>> Hello,
>>>
>>> On Friday, August 13, 2010 9:32 AM Kukjin Kim wrote:
>>>
>>> > This is just information about Samsung sdmmc stuff building error now.
>>> >
>>> > I found Marek's 'sdhci-s3c: enable SDHCI_QUIRK_NO_HISPD_BIT quirk' in the
>>> > Linus' tree.
>>> > (commit ID: a1d5646005af1247d6ae78434bb4db15b07a07b2)
>>> >
>>> > But not defined the quirk yet...so following build error happened with
>>> > s3c6400_defconfig in Linus' latest.
>>> >
>>> > drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe':
>>> > drivers/mmc/host/sdhci-s3c.c:400: error: 'SDHCI_QUIRK_NO_HISPD_BIT'
>>> > undeclared (first use in this function)
>>> > drivers/mmc/host/sdhci-s3c.c:400: error: (Each undeclared identifier is
>>> > reported only once
>>> > drivers/mmc/host/sdhci-s3c.c:400: error: for each function it appears in.)
>>> > make[4]: *** [drivers/mmc/host/sdhci-s3c.o] Error 1
>>> > make[3]: *** [drivers/mmc/host] Error 2
>>> > make[2]: *** [drivers/mmc] Error 2
>>> > make[1]: *** [drivers] Error 2
>>> >
>>> > Kyungmin Park's below patch can solve this and it is in mmotm now.
>>> > (commit ID: 2935b9e7fcc4bea3751b8d039b383b2036a7d36d)
>>> >
>>> > But I think, to update quirk definition should being in Marek's patch for
>>> > avoiding build error.
>>> > Of course, I'm not sure whether the commit order changed.
>>> > Anyway, in this case, will be solved after merging mm tree.
>>> >
>>> >
>>> > And second case is same.
>>> >
>>> > Marek's 'sdhci-s3c: add support for new card detection methods' cause
>>> > following build error.
>>> > (commit ID:17866e14f3a4f219e94f1374ece7226479418ff8)
>>> >
>>> > drivers/built-in.o: In function `sdhci_s3c_notify_change':
>>> > /home/kgene/linux/linux-2.6-mainline-dev/drivers/mmc/host/sdhci-s3c.c:255:
>>> > undefined reference to `sdhci_card_detect'
>>> > make[1]: *** [.tmp_vmlinux1] Error 1
>>> > make: *** [sub-make] Error 2

and this issue is another. check the this.
http://marc.info/?l=linux-mmc&m=128201811218629&w=3

>>> >
>>> > And Andrew's patch(b567e5dd5a34c184e5642100e752cb87e064bb97) can solve this.
>>> > (of course this needs another patches...)
>>> >
>>> > Anyway...
>>> > Marek, in future please make sure your patch has no building problem before
>>> > submitting.
>>> > (or it can help to add some kind of dependency note in your patch)
>>>
>>> My patches submited to Andrew Morton had the description and a note that they
>>> have been prepared especially for his tree, taking into account all patches
>>> that are already there (mainly a tasklets to threaded irq conversion). For me
>>> it was quite obvious that they will be merged after all other sdhci changes
>>> from that tree. I have no idea why the order of the patches has been reversed
>>> and my sdhci patches has been submitted to Linus before the other sdhci
>>> changes.
>>
>> We're talking about these:
>>
>> s5pc110-sdhci-s3c-can-override-host-capabilities.patch
>> s5pc110-sdhci-s3c-support-on-s5pc110.patch
>> sdhci-add-no-hi-speed-bit-quirk-support.patch
>>
>> I have a note that these await an ack from Ben Dooks so I held them
>> back for a closer look after -rc1.  I was unaware of this dependency.
>>
>> Ben, are you OK with those patches?
>
> These are required for support s5pc110 & s5pc210.
>
> Current sdhci on s5p has some wrong assumption. only support 4-bit
> bandwidth. and don't consider the embedded mmc like eMMC.
>
>>
>> http://userweb.kernel.org/~akpm/mmotm/broken-out/s5pc110-sdhci-s3c-can-override-host-capabilities.patch
> It required for override the host caps and pass to the mmc with correct caps
>> http://userweb.kernel.org/~akpm/mmotm/broken-out/s5pc110-sdhci-s3c-support-on-s5pc110.patch
> required for support s5pc110 and also s5pc210
>> http://userweb.kernel.org/~akpm/mmotm/broken-out/sdhci-add-no-hi-speed-bit-quirk-support.patch
> As SDHCI on s5p don't has HISPD bit in controller register. need to quirks.
>>
>> Thanks.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>