From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <ext-andriy.shevchenko@nokia.com>,
Adrian Hunter <adrian.hunter@nokia.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: make dev_to_mmc_card() macro public
Date: Thu, 19 Aug 2010 14:49:21 -0700 [thread overview]
Message-ID: <20100819144921.40d6765f.akpm@linux-foundation.org> (raw)
In-Reply-To: <1282138278-22304-1-git-send-email-ext-andriy.shevchenko@nokia.com>
On Wed, 18 Aug 2010 16:31:18 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> Conversion from struct device to struct mmc_card is used more than in one
> place. Due to this it's better to have public macro for such thing.
>
nit: generally, subsystem-specific identifiers should use their
subsystem's identifier as a prefix. So a better name for
dev_to_mmc_card() would be mmc_dev_to_card().
next prev parent reply other threads:[~2010-08-19 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 13:31 [PATCH] mmc: make dev_to_mmc_card() macro public Andy Shevchenko
2010-08-19 21:49 ` Andrew Morton [this message]
2010-08-20 7:17 ` Andy Shevchenko
2010-08-20 7:23 ` Andrew Morton
2010-08-20 7:46 ` [PATCHv2] mmc: make mmc_dev_to_card() " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819144921.40d6765f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adrian.hunter@nokia.com \
--cc=andy.shevchenko@gmail.com \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox