From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] mmc: make dev_to_mmc_card() macro public Date: Thu, 19 Aug 2010 14:49:21 -0700 Message-ID: <20100819144921.40d6765f.akpm@linux-foundation.org> References: <1282138278-22304-1-git-send-email-ext-andriy.shevchenko@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:39213 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970Ab0HSVt3 (ORCPT ); Thu, 19 Aug 2010 17:49:29 -0400 In-Reply-To: <1282138278-22304-1-git-send-email-ext-andriy.shevchenko@nokia.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , Adrian Hunter , linux-mmc@vger.kernel.org On Wed, 18 Aug 2010 16:31:18 +0300 Andy Shevchenko wrote: > Conversion from struct device to struct mmc_card is used more than in one > place. Due to this it's better to have public macro for such thing. > nit: generally, subsystem-specific identifiers should use their subsystem's identifier as a prefix. So a better name for dev_to_mmc_card() would be mmc_dev_to_card().