From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH 3/3] MMC/SD: add callback function to detect card Date: Fri, 27 Aug 2010 20:05:13 +0100 Message-ID: <20100827190513.GC20407@void.printf.net> References: <1259913309-27146-1-git-send-email-r66093@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from void.printf.net ([89.145.121.20]:57213 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755307Ab0H0TFR (ORCPT ); Fri, 27 Aug 2010 15:05:17 -0400 Content-Disposition: inline In-Reply-To: <1259913309-27146-1-git-send-email-r66093@freescale.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: r66093@freescale.com Cc: linux-mmc@vger.kernel.org, Jerry Huang Hi, On Fri, Dec 04, 2009 at 03:55:09PM +0800, r66093@freescale.com wrote: > From: Jerry Huang > > Add callback function to check if the card has been removed. > > in order to check if the card has been removed, the function mmc_send_status will send commad CMD13 to card and ask the card to send its status register to driver, which will generate interrupt repeatly and make the system bad. > Therefore, get_cd callback is used to detect the card if the driver has. > > Signed-off-by: Jerry Huang > --- > drivers/mmc/core/mmc.c | 5 ++++- > drivers/mmc/core/sd.c | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index 06084db..c5c676d 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -494,7 +494,10 @@ static void mmc_detect(struct mmc_host *host) > /* > * Just check if our card has been removed. > */ > - err = mmc_send_status(host->card, NULL); > + if (host->ops->get_cd) > + err = !host->ops->get_cd(host); > + else > + err = mmc_send_status(host->card, NULL); > > mmc_release_host(host); > > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c > index cd81c39..3cf1f38 100644 > --- a/drivers/mmc/core/sd.c > +++ b/drivers/mmc/core/sd.c > @@ -548,7 +548,10 @@ static void mmc_sd_detect(struct mmc_host *host) > /* > * Just check if our card has been removed. > */ > - err = mmc_send_status(host->card, NULL); > + if (host->ops->get_cd) > + err = !host->ops->get_cd(host); > + else > + err = mmc_send_status(host->card, NULL); > > mmc_release_host(host); > > -- > 1.6.4 This patchset wasn't replied to -- any comments on it from the list? -- Chris Ball One Laptop Per Child