* [PATCH] at91_mci.c: use resource_size()
@ 2009-12-14 19:10 H Hartley Sweeten
2010-08-27 19:08 ` [PATCH RESEND] " Chris Ball
0 siblings, 1 reply; 5+ messages in thread
From: H Hartley Sweeten @ 2009-12-14 19:10 UTC (permalink / raw)
To: kernel list, linux-mmc
Use resource_size().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
---
diff --git a/drivers/mmc/host/at91_mci.c b/drivers/mmc/host/at91_mci.c
index 63924e0..05a3fb4 100644
--- a/drivers/mmc/host/at91_mci.c
+++ b/drivers/mmc/host/at91_mci.c
@@ -992,7 +992,7 @@ static int __init at91_mci_probe(struct platform_device *pdev)
if (!res)
return -ENXIO;
- if (!request_mem_region(res->start, res->end - res->start + 1, DRIVER_NAME))
+ if (!request_mem_region(res->start, resource_size(res), DRIVER_NAME))
return -EBUSY;
mmc = mmc_alloc_host(sizeof(struct at91mci_host), &pdev->dev);
@@ -1063,7 +1063,7 @@ static int __init at91_mci_probe(struct platform_device *pdev)
/*
* Map I/O region
*/
- host->baseaddr = ioremap(res->start, res->end - res->start + 1);
+ host->baseaddr = ioremap(res->start, resource_size(res));
if (!host->baseaddr) {
ret = -ENOMEM;
goto fail1;
@@ -1135,7 +1135,7 @@ fail4:
fail5:
mmc_free_host(mmc);
fail6:
- release_mem_region(res->start, res->end - res->start + 1);
+ release_mem_region(res->start, resource_size(res));
dev_err(&pdev->dev, "probe failed, err %d\n", ret);
return ret;
}
@@ -1176,7 +1176,7 @@ static int __exit at91_mci_remove(struct platform_device *pdev)
iounmap(host->baseaddr);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- release_mem_region(res->start, res->end - res->start + 1);
+ release_mem_region(res->start, resource_size(res));
mmc_free_host(mmc);
platform_set_drvdata(pdev, NULL);
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH RESEND] at91_mci.c: use resource_size()
2009-12-14 19:10 [PATCH] at91_mci.c: use resource_size() H Hartley Sweeten
@ 2010-08-27 19:08 ` Chris Ball
2010-08-27 19:24 ` Matt Fleming
2010-08-30 7:45 ` Nicolas Ferre
0 siblings, 2 replies; 5+ messages in thread
From: Chris Ball @ 2010-08-27 19:08 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: akpm, linux-mmc
From: H Hartley Sweeten <hsweeten@visionengravers.com>
Date: Mon, 14 Dec 2009 14:10:26 -0500
Use resource_size().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
[cjb: rebased patch against Linus]
Signed-off-by: Chris Ball <cjb@laptop.org>
---
drivers/mmc/host/at91_mci.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/at91_mci.c b/drivers/mmc/host/at91_mci.c
index 5f3a599..3995db3 100644
--- a/drivers/mmc/host/at91_mci.c
+++ b/drivers/mmc/host/at91_mci.c
@@ -927,7 +927,7 @@ static int __init at91_mci_probe(struct platform_device *pdev)
if (!res)
return -ENXIO;
- if (!request_mem_region(res->start, res->end - res->start + 1, DRIVER_NAME))
+ if (!request_mem_region(res->start, resource_size(res), DRIVER_NAME))
return -EBUSY;
mmc = mmc_alloc_host(sizeof(struct at91mci_host), &pdev->dev);
@@ -1016,7 +1016,7 @@ static int __init at91_mci_probe(struct platform_device *pdev)
/*
* Map I/O region
*/
- host->baseaddr = ioremap(res->start, res->end - res->start + 1);
+ host->baseaddr = ioremap(res->start, resource_size(res));
if (!host->baseaddr) {
ret = -ENOMEM;
goto fail1;
@@ -1092,7 +1092,7 @@ fail4b:
fail5:
mmc_free_host(mmc);
fail6:
- release_mem_region(res->start, res->end - res->start + 1);
+ release_mem_region(res->start, resource_size(res));
dev_err(&pdev->dev, "probe failed, err %d\n", ret);
return ret;
}
@@ -1137,7 +1137,7 @@ static int __exit at91_mci_remove(struct platform_device *pdev)
iounmap(host->baseaddr);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- release_mem_region(res->start, res->end - res->start + 1);
+ release_mem_region(res->start, resource_size(res));
mmc_free_host(mmc);
platform_set_drvdata(pdev, NULL);
--
1.7.0.1
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH RESEND] at91_mci.c: use resource_size()
2010-08-27 19:08 ` [PATCH RESEND] " Chris Ball
@ 2010-08-27 19:24 ` Matt Fleming
2010-08-28 15:05 ` Jean-Christophe PLAGNIOL-VILLARD
2010-08-30 7:45 ` Nicolas Ferre
1 sibling, 1 reply; 5+ messages in thread
From: Matt Fleming @ 2010-08-27 19:24 UTC (permalink / raw)
To: Chris Ball
Cc: H Hartley Sweeten, akpm, linux-mmc, Nicolas Ferre,
linux-arm-kernel
[Adding maintainer to CC]
On Fri, Aug 27, 2010 at 08:08:13PM +0100, Chris Ball wrote:
> From: H Hartley Sweeten <hsweeten@visionengravers.com>
> Date: Mon, 14 Dec 2009 14:10:26 -0500
>
> Use resource_size().
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> [cjb: rebased patch against Linus]
> Signed-off-by: Chris Ball <cjb@laptop.org>
> ---
> drivers/mmc/host/at91_mci.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/at91_mci.c b/drivers/mmc/host/at91_mci.c
> index 5f3a599..3995db3 100644
> --- a/drivers/mmc/host/at91_mci.c
> +++ b/drivers/mmc/host/at91_mci.c
> @@ -927,7 +927,7 @@ static int __init at91_mci_probe(struct platform_device *pdev)
> if (!res)
> return -ENXIO;
>
> - if (!request_mem_region(res->start, res->end - res->start + 1, DRIVER_NAME))
> + if (!request_mem_region(res->start, resource_size(res), DRIVER_NAME))
> return -EBUSY;
>
> mmc = mmc_alloc_host(sizeof(struct at91mci_host), &pdev->dev);
> @@ -1016,7 +1016,7 @@ static int __init at91_mci_probe(struct platform_device *pdev)
> /*
> * Map I/O region
> */
> - host->baseaddr = ioremap(res->start, res->end - res->start + 1);
> + host->baseaddr = ioremap(res->start, resource_size(res));
> if (!host->baseaddr) {
> ret = -ENOMEM;
> goto fail1;
> @@ -1092,7 +1092,7 @@ fail4b:
> fail5:
> mmc_free_host(mmc);
> fail6:
> - release_mem_region(res->start, res->end - res->start + 1);
> + release_mem_region(res->start, resource_size(res));
> dev_err(&pdev->dev, "probe failed, err %d\n", ret);
> return ret;
> }
> @@ -1137,7 +1137,7 @@ static int __exit at91_mci_remove(struct platform_device *pdev)
>
> iounmap(host->baseaddr);
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - release_mem_region(res->start, res->end - res->start + 1);
> + release_mem_region(res->start, resource_size(res));
>
> mmc_free_host(mmc);
> platform_set_drvdata(pdev, NULL);
> --
> 1.7.0.1
>
> --
> Chris Ball <cjb@laptop.org> <http://printf.net/>
> One Laptop Per Child
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH RESEND] at91_mci.c: use resource_size()
2010-08-27 19:24 ` Matt Fleming
@ 2010-08-28 15:05 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2010-08-28 15:05 UTC (permalink / raw)
To: Matt Fleming
Cc: Nicolas Ferre, linux-mmc, H Hartley Sweeten, Chris Ball, akpm,
linux-arm-kernel
On 20:24 Fri 27 Aug , Matt Fleming wrote:
> [Adding maintainer to CC]
>
> On Fri, Aug 27, 2010 at 08:08:13PM +0100, Chris Ball wrote:
> > From: H Hartley Sweeten <hsweeten@visionengravers.com>
> > Date: Mon, 14 Dec 2009 14:10:26 -0500
> >
> > Use resource_size().
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > [cjb: rebased patch against Linus]
> > Signed-off-by: Chris Ball <cjb@laptop.org>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Bset Regards,
J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] at91_mci.c: use resource_size()
2010-08-27 19:08 ` [PATCH RESEND] " Chris Ball
2010-08-27 19:24 ` Matt Fleming
@ 2010-08-30 7:45 ` Nicolas Ferre
1 sibling, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2010-08-30 7:45 UTC (permalink / raw)
To: Chris Ball; +Cc: H Hartley Sweeten, akpm, linux-mmc
Le 27/08/2010 21:08, Chris Ball :
> From: H Hartley Sweeten <hsweeten@visionengravers.com>
> Date: Mon, 14 Dec 2009 14:10:26 -0500
>
> Use resource_size().
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> [cjb: rebased patch against Linus]
> Signed-off-by: Chris Ball <cjb@laptop.org>
A bit late but you can add my:
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/mmc/host/at91_mci.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/at91_mci.c b/drivers/mmc/host/at91_mci.c
> index 5f3a599..3995db3 100644
> --- a/drivers/mmc/host/at91_mci.c
> +++ b/drivers/mmc/host/at91_mci.c
> @@ -927,7 +927,7 @@ static int __init at91_mci_probe(struct platform_device *pdev)
> if (!res)
> return -ENXIO;
>
> - if (!request_mem_region(res->start, res->end - res->start + 1, DRIVER_NAME))
> + if (!request_mem_region(res->start, resource_size(res), DRIVER_NAME))
> return -EBUSY;
>
> mmc = mmc_alloc_host(sizeof(struct at91mci_host), &pdev->dev);
> @@ -1016,7 +1016,7 @@ static int __init at91_mci_probe(struct platform_device *pdev)
> /*
> * Map I/O region
> */
> - host->baseaddr = ioremap(res->start, res->end - res->start + 1);
> + host->baseaddr = ioremap(res->start, resource_size(res));
> if (!host->baseaddr) {
> ret = -ENOMEM;
> goto fail1;
> @@ -1092,7 +1092,7 @@ fail4b:
> fail5:
> mmc_free_host(mmc);
> fail6:
> - release_mem_region(res->start, res->end - res->start + 1);
> + release_mem_region(res->start, resource_size(res));
> dev_err(&pdev->dev, "probe failed, err %d\n", ret);
> return ret;
> }
> @@ -1137,7 +1137,7 @@ static int __exit at91_mci_remove(struct platform_device *pdev)
>
> iounmap(host->baseaddr);
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - release_mem_region(res->start, res->end - res->start + 1);
> + release_mem_region(res->start, resource_size(res));
>
> mmc_free_host(mmc);
> platform_set_drvdata(pdev, NULL);
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-08-30 8:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-14 19:10 [PATCH] at91_mci.c: use resource_size() H Hartley Sweeten
2010-08-27 19:08 ` [PATCH RESEND] " Chris Ball
2010-08-27 19:24 ` Matt Fleming
2010-08-28 15:05 ` Jean-Christophe PLAGNIOL-VILLARD
2010-08-30 7:45 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).