linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kyungmin Park <kmpark@infradead.org>,
	linux-mmc@vger.kernel.org, "George G. Davis" <gdavis@mvista.com>,
	Zhangfei Gao <zgao6@marvell.com>
Subject: [PATCH RESEND] sdhci: Enable high speed support for MMC cards
Date: Mon, 30 Aug 2010 16:56:44 +0100	[thread overview]
Message-ID: <20100830155644.GA13076@void.printf.net> (raw)
In-Reply-To: <AANLkTikswH2GdmXvRBWoeJcbrAn+JbzLTOA9fkPyV=fB@mail.gmail.com>

On Mon, Aug 30, 2010 at 10:34:48AM +0900, Kyungmin Park wrote:
> right, it's required patch and should be merged at this rc window.

Okay.  Andrew, would you mind sending the patch below to Linus for
-rc4?  (If you'd rather it go through someone else, that's fine.)

> > -       if (ios->timing == MMC_TIMING_SD_HS &&
> > +       if ((ios->timing == MMC_TIMING_SD_HS ||
> > +            ios->timing == MMC_TIMING_MMC_HS) &&
> >            !(host->quirks & SDHCI_QUIRK_NO_HISPD_BIT))
> >                ctrl |= SDHCI_CTRL_HISPD;
> >        else
> >
> Does it need? I mean when probing the mmc card it doesn't have
> MMC_TIMING_MMC_HS. so it can't trigger the this condition at my
> environment.

I agree; MMC_TIMING_MMC_HS is set in response to moving to HS, which
can't happen without this flag.  George, let us know if you still 
think this is necessary.

Here's Zhangfei's patch for merging:

From: Zhangfei Gao <zgao6@marvell.com>
Date: Mon, 16 Aug 2010 21:15:32 -0400
Subject: [PATCH] sdhci: Enable high-speed support for MMC cards

Support MMC_CAP_MMC_HIGHSPEED.

Signed-off-by: Zhangfei Gao <zgao6@marvell.com>
Acked-by: Matt Fleming <matt@console-pimps.org>
Acked-by: Kyungmin Park <kmpark@infradead.org>
Signed-off-by: Chris Ball <cjb@laptop.org>
---
 drivers/mmc/host/sdhci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 401527d..87ab234 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1824,7 +1824,7 @@ int sdhci_add_host(struct sdhci_host *host)
 		mmc->caps |= MMC_CAP_4_BIT_DATA;
 
 	if (caps & SDHCI_CAN_DO_HISPD)
-		mmc->caps |= MMC_CAP_SD_HIGHSPEED;
+		mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
 
 	if (host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION)
 		mmc->caps |= MMC_CAP_NEEDS_POLL;
-- 
1.7.0.1

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2010-08-30 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 19:19 [RFC/PATCH RESEND] mmc: sdhci: Enable high speed support for MMC cards Chris Ball
2010-08-28  5:39 ` Kyungmin Park
2010-08-28 16:24   ` Chris Ball
2010-08-30  1:34     ` Kyungmin Park
2010-08-30 15:56       ` Chris Ball [this message]
2010-09-17 22:14         ` [PATCH RESEND] " Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100830155644.GA13076@void.printf.net \
    --to=cjb@laptop.org \
    --cc=akpm@linux-foundation.org \
    --cc=gdavis@mvista.com \
    --cc=kmpark@infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=zgao6@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).