From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-pm@lists.linux-foundation.org, linux-mmc@vger.kernel.org
Subject: Re: [linux-pm] generic runtime pm callbacks
Date: Mon, 6 Sep 2010 21:07:40 +0200 [thread overview]
Message-ID: <201009062107.40677.rjw@sisk.pl> (raw)
In-Reply-To: <20100906132241.GH8381@sirena.org.uk>
On Monday, September 06, 2010, Mark Brown wrote:
> On Mon, Sep 06, 2010 at 03:32:09PM +0300, Ohad Ben-Cohen wrote:
>
> > That may result in some drivers defining nop handlers, just to return
> > 0 (in case there's nothing else they need to do).
>
> > Do we want that ?
>
> Funnily enough I was about to report this issue too - it doesn't look
> great in the driver code. My use case is using runtime PM in an MFD to
> communicate status to the parent devices. The subdevices are just
> indicating that they are idle to the parent and have no reason to do
> anything in a suspend or resume callback.
>
> > Alternatively, we may want to allow drivers to enable Runtime PM (by
> > taking the appropriate action for their subsystem, e.g. calling
> > put_noidle in probe and get_noresume in remove), but still not define
> > any runtime pm handlers (implicitly always returning a success), with
> > something like:
>
> This would be my preferred solution.
OK
Please submit the patch with appropriate changelog and I'll apply it.
Thanks,
Rafael
prev parent reply other threads:[~2010-09-06 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 12:32 generic runtime pm callbacks Ohad Ben-Cohen
2010-09-06 13:22 ` [linux-pm] " Mark Brown
2010-09-06 14:30 ` Alan Stern
2010-09-06 14:59 ` Mark Brown
2010-09-06 19:07 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009062107.40677.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox