From: Alan Cox <alan@linux.intel.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org
Subject: Re: [PATCH 1/7] sdhci: Rework some of the quirk behaviour
Date: Tue, 14 Sep 2010 15:20:40 +0100 [thread overview]
Message-ID: <20100914152040.3d129706@linux.intel.com> (raw)
In-Reply-To: <20100914143437.GG2629@pengutronix.de>
> > drivers/mmc/host/Kconfig | 11 ++
> > drivers/mmc/host/Makefile | 1
> > drivers/mmc/host/sdhci-intel-mid.c | 163
> > ++++++++++++++++++++++++++++++++++++
>
> Why are those added here and not in patch 3/7?
I thought it would be useful to add the hooks and show how they are
used in one - I can split that easily enough.
> > + * ADMA operation is disabled for Moorestown platform due to
> > + * hardware bugs.
> > + */
> > +static int mrst_hc0_probe(struct sdhci_pci_chip *chip)
> > +{
> > + /*
> > + * slots number is fixed here for MRST as SDIO3 is never
> > used and has
> > + * hardware bugs.
> > + */
> > + chip->num_slots = 1;
> > + return 0;
> > +}
>
> Why is this function here and not in sdhci-intel-mid.c?
So it follows the pattern of the other drivers, so it doesn't need an
extra exported symbol (at about ten times the size of the function).
We could move probe into host_ops I guess but that means tweaking all
the other drivers which I cannot test.
I guess the other way to do it would be not to have a separate file but
to stick it all in sdhci-pci ?
> > mmc->max_blk_size = (caps & SDHCI_MAX_BLOCK_MASK)
> > >> SDHCI_MAX_BLOCK_SHIFT;
> > - if (mmc->max_blk_size >= 3) {
> > + if (mmc->max_blk_size > 3) {
>
> Why this change? Not mentioned in the changelog. And wrong according
> to the simplified standard v2. Is it V3 material?
That's got in by mistake. I thought I'd got all the spec related bits
stripped out.
I actually suspect for the more general case of cleaning up some of the
other driver quirks we need a couple more callbacks but its hard to
sure.
next prev parent reply other threads:[~2010-09-14 15:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 17:38 [PATCH 0/7] Intel MID SDHCI support (take two) Alan Cox
2010-09-13 17:38 ` [PATCH 1/7] sdhci: Rework some of the quirk behaviour Alan Cox
2010-09-14 14:34 ` Wolfram Sang
2010-09-14 14:20 ` Alan Cox [this message]
2010-09-13 17:39 ` [PATCH 2/7] sdhci: Allow the probe handler to override slots Alan Cox
2010-09-13 17:39 ` [PATCH 3/7] sdhci: Intel Medfield support Alan Cox
2010-09-13 17:39 ` [PATCH 4/7] mmc: serialization support Alan Cox
2010-09-13 17:39 ` [PATCH 5/7] sdhci: Tidy up spaces in sdhci_intel_mid Alan Cox
2010-09-14 14:21 ` Wolfram Sang
2010-09-14 13:40 ` Alan Cox
2010-09-14 14:45 ` Wolfram Sang
2010-09-14 14:21 ` Alan Cox
2010-09-14 16:57 ` Chris Ball
2010-09-14 16:41 ` Alan Cox
2010-09-14 20:00 ` Wolfram Sang
2010-09-13 17:39 ` [PATCH 6/7] sdhci_pci: Tidy this as well Alan Cox
2010-09-13 17:39 ` [PATCH 7/7] sdhci: Tidy up sdhci.c Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914152040.3d129706@linux.intel.com \
--to=alan@linux.intel.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox