public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Chris Ball <cjb@laptop.org>
Cc: Wolfram Sang <w.sang@pengutronix.de>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 5/7] sdhci: Tidy up spaces in sdhci_intel_mid
Date: Tue, 14 Sep 2010 17:41:25 +0100	[thread overview]
Message-ID: <20100914174125.387f4b29@linux.intel.com> (raw)
In-Reply-To: <20100914165743.GA19431@void.printf.net>

> into 2.6.37, which is worth trying for.  I like Wolfram's suggested 
> patchset format.  Alan, do you feel comfortable re-doing this in time
> for some testing before the merge window opens, or should I help?

Redoing it shouldn't be a problem, getting testing of the MID bits
will slow it down a fair bit. I'm not in a huge rush - I need to get
the SFI device patches merged before an upstream kernel will actually
be useful on a MID device.

> The big question seems to be whether the approach the patchset takes
> -- moving from quirks to hooks, extending sdhci.c without creating a 
> full driver, and the initial choice of overridable hooks -- makes
> sense.  I'd be happy to hear everyone's thoughts on that.

I'd rather see that discussion happen and then redo the MID patches to
match whatever turns out to suit a more generalised set of driver
tidyups this way than push it in ASAP.

That also fits my timetable better as I've got an exam coming up early
October and other stuff to push before I run off and hide revising.

  reply	other threads:[~2010-09-14 17:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 17:38 [PATCH 0/7] Intel MID SDHCI support (take two) Alan Cox
2010-09-13 17:38 ` [PATCH 1/7] sdhci: Rework some of the quirk behaviour Alan Cox
2010-09-14 14:34   ` Wolfram Sang
2010-09-14 14:20     ` Alan Cox
2010-09-13 17:39 ` [PATCH 2/7] sdhci: Allow the probe handler to override slots Alan Cox
2010-09-13 17:39 ` [PATCH 3/7] sdhci: Intel Medfield support Alan Cox
2010-09-13 17:39 ` [PATCH 4/7] mmc: serialization support Alan Cox
2010-09-13 17:39 ` [PATCH 5/7] sdhci: Tidy up spaces in sdhci_intel_mid Alan Cox
2010-09-14 14:21   ` Wolfram Sang
2010-09-14 13:40     ` Alan Cox
2010-09-14 14:45       ` Wolfram Sang
2010-09-14 14:21         ` Alan Cox
2010-09-14 16:57         ` Chris Ball
2010-09-14 16:41           ` Alan Cox [this message]
2010-09-14 20:00             ` Wolfram Sang
2010-09-13 17:39 ` [PATCH 6/7] sdhci_pci: Tidy this as well Alan Cox
2010-09-13 17:39 ` [PATCH 7/7] sdhci: Tidy up sdhci.c Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100914174125.387f4b29@linux.intel.com \
    --to=alan@linux.intel.com \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox