RE: [PATCH 2/5] ARM: S5PV310: Add HSMMC support into S5PV310 and S5PC210

Jeongbae Seo
2010-10-05T06:46:51Z

Marek Szyprowski wrote:
> Hello,
>
> I'm sorry for a late replay, I've just noticed this patch and have some
> comments.
>
> On Thursday, September 16, 2010 10:37 AM Jeongbae Seo wrote:
>
> > From: Hyuk Lee <hyuk1.lee@samsung.com>
> >
> > This patch adds to use of HSMMC on S5PV310 and S5PC210.
> > The HSMMC platform data like card detect, data bus width
> > and capability is configured.
> >
> > Signed-off-by: Hyuk Lee <hyuk1.lee@samsung.com>
> > Signed-off-by: Jeongbae Seo <jeongbae.seo@samsung.com>
> > ---
> > arch/arm/mach-s5pv310/cpu.c | 7 +++
> > arch/arm/mach-s5pv310/mach-smdkc210.c | 50
> ++++++++++++++++++++++++
> > arch/arm/mach-s5pv310/mach-smdkv310.c | 50
> ++++++++++++++++++++++++
> > arch/arm/plat-samsung/include/plat/sdhci.h | 57
> ++++++++++++++++++++++++++++
> > 4 files changed, 164 insertions(+), 0 deletions(-)
>
> IMHO, changes to arch/arm/mach-s5pv310/{cpu.c, include/plat/sdhci.h}
> should be separated from changes to board specific changes
> (arch/arm/mach-s5pv310/mach-smdk*.c), so this patch should be split
> into 2 separate patches.

Hi, Marek

Okay, I'll make it as two patches.
Thanks for your comments.

Best Regards
Jeongbae Seo