public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: Chris Ball <cjb@laptop.org>,
	linux-mmc@vger.kernel.org, Kyungmin Park <kmpark@infradead.org>,
	eric.y.miao@gmail.com, Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller
Date: Mon, 20 Sep 2010 15:10:56 +0200	[thread overview]
Message-ID: <20100920131055.GE4058@pengutronix.de> (raw)
In-Reply-To: <AANLkTin28uj+L+AyUYVwoAyaUOmpfw3tc6JFEcVgtXBy@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1673 bytes --]

On Mon, Sep 20, 2010 at 08:09:26AM -0400, zhangfei gao wrote:
> On Mon, Sep 20, 2010 at 5:50 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> > On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote:
> >
> >> diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c
> >> new file mode 100644
> >> index 0000000..3e091c1
> >> --- /dev/null
> >> +++ b/drivers/mmc/host/sdhci-pxa.c
> >> @@ -0,0 +1,253 @@
> >> +/* linux/drivers/mmc/host/sdhci-pxa.c
> >> + *
> >> + * Copyright 2010 Marvell
> >> + *      Zhangfei Gao <zhangfei.gao@marvell.com>
> >> + *
> >> + * This program is free software; you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License version 2 as
> >> + * published by the Free Software Foundation.
> >> + */
> >> +
> >> +/* Supports:
> >> + * SDHCI support for MMP2/PXA910/PXA168
> >> + *
> >> + * Based on sdhci-platfm.c
> >> + */
> >
> > Why is it only "based on" and not directly using it?
> 
> Thanks for your suggestion.
> This is the first stage, already implement sd card function, we will
> have some patches later to enhance the driver.
> We have to access many private registers to enable specific control.
> Besides some sdio device need some specific control, like marvell 8787
> host sleep, it is much reasonable to implement inside the driver.

Hmm, which hooks are missing for you to implement this as an extension
of the pltfm-driver? Maybe it makes sense to simply add this hook?

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2010-09-20 13:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20  9:46 [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller zhangfei gao
2010-09-20  9:50 ` Wolfram Sang
2010-09-20 12:09   ` zhangfei gao
2010-09-20 13:10     ` Wolfram Sang [this message]
2010-09-21  8:24       ` zhangfei gao
2010-09-21 10:11         ` Wolfram Sang
2010-09-21 10:18           ` Eric Miao
2010-09-21 16:18           ` Chris Ball
2010-09-21  1:03 ` Chris Ball
2010-09-21  3:16   ` zhangfei gao
2010-09-22  2:27     ` Chris Ball
2010-09-21  9:42 ` claud yu
2010-09-26  9:05   ` zhangfei gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100920131055.GE4058@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=cjb@laptop.org \
    --cc=eric.y.miao@gmail.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=kmpark@infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox