From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: mmotm 2010-09-15 - BUG in mmc driver calling led_trigger_event() Date: Wed, 22 Sep 2010 10:32:44 +0400 Message-ID: <20100922063244.GA19324@oksana.dev.rtsoft.ru> References: <201009152352.o8FNqXGr022752@imap1.linux-foundation.org> <8581.1285124507@localhost> <20100921201758.66841897.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:52274 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543Ab0IVGct (ORCPT ); Wed, 22 Sep 2010 02:32:49 -0400 Content-Disposition: inline In-Reply-To: <20100921201758.66841897.akpm@linux-foundation.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Andrew Morton Cc: Valdis.Kletnieks@vt.edu, Richard Purdie , Chris Ball , Hein_Tibosch , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org On Tue, Sep 21, 2010 at 08:17:58PM -0700, Andrew Morton wrote: [...] > led_trigger_event() does read_lock() then calls led_set_brightness() > which indirectly calls sdhci_led_control() which does mutex_lock(). > > That mutex_lock() was added by sdhci-turn-host-lock-into-a-mutex.patch. > > Anton, those patches aren't going very well - I think I'll drop Yep, please drop it. Thanks, > sdhci-turn-timeout-timer-into-delayed-work.patch > sdhci-use-work-structs-instead-of-tasklets.patch > sdhci-use-work-structs-instead-of-tasklets-fix.patch > sdhci-clear-interrupt-status-register-just-once.patch > sdhci-use-threaded-irq-handler.patch > sdhci-turn-host-lock-into-a-mutex.patch > sdhci-get-rid-of-card-detect-work.patch > sdhci-get-rid-of-card-detect-work-fix.patch > sdhci-get-rid-of-mdelays-where-it-is-safe-and-makes-sense.patch > sdhci-use-jiffies-instead-of-a-timeout-counter.patch > -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2