public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Philip Rakity <prakity@marvell.com>
Cc: Adrian Hunter <adrian.hunter@nokia.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Mark Brown <markb@marvell.com>
Subject: Re: [PATCH] sdhci: print out controller name for register debug
Date: Thu, 23 Sep 2010 00:08:06 +0100	[thread overview]
Message-ID: <20100922230805.GA6659@void.printf.net> (raw)
In-Reply-To: <1CE3965A-95E9-41A7-8333-432778AAC336@marvell.com>

Hi Philip,

On Wed, Sep 22, 2010 at 03:25:13PM -0700, Philip Rakity wrote:
> Subject: [PATCH] sdhci: print out controller name for register debug
> 
> In a multi-controller environment it is helpful to know which controller
> has problems.
> 
> Signed-off-by: Philip Rakity <prakity@marvell.com>
> ---
>  drivers/mmc/host/sdhci.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index e2b1f32..6b8ca32 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -47,7 +47,8 @@ static void sdhci_finish_command(struct sdhci_host *);
>  
>  static void sdhci_dumpregs(struct sdhci_host *host)
>  {
> -	printk(KERN_DEBUG DRIVER_NAME ": ============== REGISTER DUMP ==============\n");
> +	printk(KERN_DEBUG DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
> +		mmc_hostname(host->mmc));
>  
>  	printk(KERN_DEBUG DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
>  		sdhci_readl(host, SDHCI_DMA_ADDRESS),

Thanks, pushed to mmc-next; I'm surprised no-one noticed this before. :)

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2010-09-22 23:08 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-12  5:17 RE: Bug in mmc.c == stops eMMC toshiba from working - sector check not good (PATCH) Philip Rakity
2010-03-13  5:09 ` Patch: eMMC boot partition needs to be deactivated for linux to find user partitions Philip Rakity
2010-03-15  8:08   ` Adrian Hunter
2010-03-15 18:32     ` Features vs versions (Was: Patch: eMMC boot partition needs to be deactivated for linux to find user partitions) Edward Falk
2010-03-15 18:54       ` Johnson, Charles F
2010-03-16  1:44     ` Patch: eMMC boot partition needs to be deactivated for linux to find user partitions Philip Rakity
2010-03-20  5:12     ` Philip Rakity
2010-03-22  8:25       ` Adrian Hunter
     [not found]         ` <639D1595-D908-473C-9A41-71B493DCD0C0@marvell.com>
2010-03-29  7:12           ` Adrian Hunter
2010-09-19 21:46             ` [PATCH] sdhci: add quirk for controllers that don't support write only detect Philip Rakity
2010-09-20  6:14               ` Wolfram Sang
2010-09-20 16:00                 ` Philip Rakity
2010-09-21  5:43                   ` [PATCH] sdhci: allow for eMMC 74 clock generation by controller Philip Rakity
2010-09-21  6:04                     ` Adrian Hunter
2010-09-21 15:06                       ` Philip Rakity
2010-09-21 16:58                         ` Wolfram Sang
     [not found]                           ` <15EE115E-4B8A-4314-BD7A-3FB24A1F1BB6@marvell.com>
2010-09-22  8:56                             ` Wolfram Sang
2010-09-22  7:57                         ` Adrian Hunter
2010-09-22 22:25                         ` [PATCH] sdhci: print out controller name for register debug Philip Rakity
2010-09-22 23:08                           ` Chris Ball [this message]
2010-09-23  8:39                             ` Wolfram Sang
2010-09-23 16:12                               ` Chris Ball
2010-09-23 17:11                                 ` Wolfram Sang
2010-09-21  6:48                     ` [PATCH] sdhci: allow for eMMC 74 clock generation by controller Wolfram Sang
2010-09-23 15:24                     ` Philip Rakity
2010-09-23 15:49                       ` Subject: [PATCH] sdhci: Show SD Command when doing debug printks Philip Rakity
2010-10-07 23:58                       ` [PATCH] sdhci: allow for eMMC 74 clock generation by controller Chris Ball
     [not found]                 ` <763CD352-8557-46F1-89D6-5596C40C435E@marvell.com>
2010-09-24  4:49                   ` [PATCH] sdhci: add quirk for controllers that don't support write only detect Wolfram Sang
2010-09-24  9:34                     ` Philip Rakity
2010-03-16 20:25 ` Bug in mmc.c == stops eMMC toshiba from working - sector check not good (REPOST) (PATCH) Philip Rakity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100922230805.GA6659@void.printf.net \
    --to=cjb@laptop.org \
    --cc=adrian.hunter@nokia.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=markb@marvell.com \
    --cc=prakity@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox