Re: [PATCH] sdhci: print out controller name for register debug

[Wolfram Sang <w.sang@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

On Thu, Sep 23, 2010 at 12:08:06AM +0100, Chris Ball wrote:
> Hi Philip,
> 
> On Wed, Sep 22, 2010 at 03:25:13PM -0700, Philip Rakity wrote:
> > Subject: [PATCH] sdhci: print out controller name for register debug
> > 
> > In a multi-controller environment it is helpful to know which controller
> > has problems.
> > 
> > Signed-off-by: Philip Rakity <prakity@marvell.com>
> > ---
> >  drivers/mmc/host/sdhci.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> > index e2b1f32..6b8ca32 100644
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc/host/sdhci.c
> > @@ -47,7 +47,8 @@ static void sdhci_finish_command(struct sdhci_host *);
> >  
> >  static void sdhci_dumpregs(struct sdhci_host *host)
> >  {
> > -	printk(KERN_DEBUG DRIVER_NAME ": ============== REGISTER DUMP ==============\n");
> > +	printk(KERN_DEBUG DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
> > +		mmc_hostname(host->mmc));
> >  
> >  	printk(KERN_DEBUG DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
> >  		sdhci_readl(host, SDHCI_DMA_ADDRESS),
> 
> Thanks, pushed to mmc-next; I'm surprised no-one noticed this before. :)

Uh, that was fast. I would have preferred to switch the whole printout
to dev_dbg?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]