From: Wolfram Sang <w.sang@pengutronix.de>
To: Peppe CAVALLARO <peppe.cavallaro@st.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"matt@console-pimps.org" <matt@console-pimps.org>
Subject: Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)
Date: Thu, 23 Sep 2010 11:51:42 +0200 [thread overview]
Message-ID: <20100923095142.GC2994@pengutronix.de> (raw)
In-Reply-To: <4C9B1E32.4070700@st.com>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
> static int mmc_pad_resources(struct sdhci_host *sdhci)
> {
> if (!devm_stm_pad_claim(sdhci->mmc->parent,
> &stx7108_mmc_pad_config,
> dev_name(sdhci->mmc->parent)))
> return -ENODEV;
>
> return 0;
> }
>
> static struct sdhci_pltfm_data stx7108_mmc_platform_data = {
> .init = &mmc_pad_resources,
You can drop the &
> .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
> };
>
> static struct platform_device stx7108_mmc_device = {
> .name = "sdhci",
>
> [snip]
All in all, this looks like the right way! A good example how to
slightly update and then use the pltfm-driver. Redundant code saved and
benefits for all added :)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-09-23 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 8:20 [PATCH] mmc: add SDHCI driver for STM platforms (V2) Giuseppe CAVALLARO
2010-09-20 8:38 ` Wolfram Sang
2010-09-21 9:21 ` Peppe CAVALLARO
2010-09-21 9:44 ` Wolfram Sang
2010-09-22 13:31 ` Peppe CAVALLARO
2010-09-22 14:12 ` Wolfram Sang
2010-09-22 14:35 ` Peppe CAVALLARO
2010-09-23 6:48 ` Peppe CAVALLARO
2010-09-23 8:48 ` Wolfram Sang
2010-09-23 9:30 ` Peppe CAVALLARO
2010-09-23 9:51 ` Wolfram Sang [this message]
2010-09-23 10:05 ` Peppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923095142.GC2994@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox