From: Chris Ball <cjb@laptop.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Philip Rakity <prakity@marvell.com>,
Adrian Hunter <adrian.hunter@nokia.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Mark Brown <markb@marvell.com>
Subject: Re: [PATCH] sdhci: print out controller name for register debug
Date: Thu, 23 Sep 2010 17:12:15 +0100 [thread overview]
Message-ID: <20100923161215.GA27023@void.printf.net> (raw)
In-Reply-To: <20100923083946.GA2994@pengutronix.de>
Hi Wolfram,
On Thu, Sep 23, 2010 at 10:39:46AM +0200, Wolfram Sang wrote:
> Uh, that was fast.
Sorry, you're right, was fast. I'm okay with improving patches after
they enter mmc-next, but I'll leave more time for comments on patches
in future before merging.
> I would have preferred to switch the whole printout to dev_dbg?
That's a much bigger change, though -- you'd be making sdhci_dumpregs()
a no-op unless CONFIG_MMC_DEBUG is defined, right? That's a change in
semantics, since it's intentionally called from many non-debug error
paths right now.
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-09-23 16:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 5:17 RE: Bug in mmc.c == stops eMMC toshiba from working - sector check not good (PATCH) Philip Rakity
2010-03-13 5:09 ` Patch: eMMC boot partition needs to be deactivated for linux to find user partitions Philip Rakity
2010-03-15 8:08 ` Adrian Hunter
2010-03-15 18:32 ` Features vs versions (Was: Patch: eMMC boot partition needs to be deactivated for linux to find user partitions) Edward Falk
2010-03-15 18:54 ` Johnson, Charles F
2010-03-16 1:44 ` Patch: eMMC boot partition needs to be deactivated for linux to find user partitions Philip Rakity
2010-03-20 5:12 ` Philip Rakity
2010-03-22 8:25 ` Adrian Hunter
[not found] ` <639D1595-D908-473C-9A41-71B493DCD0C0@marvell.com>
2010-03-29 7:12 ` Adrian Hunter
2010-09-19 21:46 ` [PATCH] sdhci: add quirk for controllers that don't support write only detect Philip Rakity
2010-09-20 6:14 ` Wolfram Sang
2010-09-20 16:00 ` Philip Rakity
2010-09-21 5:43 ` [PATCH] sdhci: allow for eMMC 74 clock generation by controller Philip Rakity
2010-09-21 6:04 ` Adrian Hunter
2010-09-21 15:06 ` Philip Rakity
2010-09-21 16:58 ` Wolfram Sang
[not found] ` <15EE115E-4B8A-4314-BD7A-3FB24A1F1BB6@marvell.com>
2010-09-22 8:56 ` Wolfram Sang
2010-09-22 7:57 ` Adrian Hunter
2010-09-22 22:25 ` [PATCH] sdhci: print out controller name for register debug Philip Rakity
2010-09-22 23:08 ` Chris Ball
2010-09-23 8:39 ` Wolfram Sang
2010-09-23 16:12 ` Chris Ball [this message]
2010-09-23 17:11 ` Wolfram Sang
2010-09-21 6:48 ` [PATCH] sdhci: allow for eMMC 74 clock generation by controller Wolfram Sang
2010-09-23 15:24 ` Philip Rakity
2010-09-23 15:49 ` Subject: [PATCH] sdhci: Show SD Command when doing debug printks Philip Rakity
2010-10-07 23:58 ` [PATCH] sdhci: allow for eMMC 74 clock generation by controller Chris Ball
[not found] ` <763CD352-8557-46F1-89D6-5596C40C435E@marvell.com>
2010-09-24 4:49 ` [PATCH] sdhci: add quirk for controllers that don't support write only detect Wolfram Sang
2010-09-24 9:34 ` Philip Rakity
2010-03-16 20:25 ` Bug in mmc.c == stops eMMC toshiba from working - sector check not good (REPOST) (PATCH) Philip Rakity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923161215.GA27023@void.printf.net \
--to=cjb@laptop.org \
--cc=adrian.hunter@nokia.com \
--cc=linux-mmc@vger.kernel.org \
--cc=markb@marvell.com \
--cc=prakity@marvell.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox