From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [patch] sdhci: correct f_min in sd 3.0 Date: Fri, 24 Sep 2010 03:06:09 +0100 Message-ID: <20100924020609.GA9901@void.printf.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from void.printf.net ([89.145.121.20]:55160 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754843Ab0IXCGK (ORCPT ); Thu, 23 Sep 2010 22:06:10 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: zhangfei gao Cc: linux-mmc@vger.kernel.org, Kyungmin Park Hi, On Mon, Sep 20, 2010 at 03:32:58AM -0400, zhangfei gao wrote: > From: Zhangfei Gao > Date: Mon, 20 Sep 2010 15:15:18 -0400 > Subject: [PATCH 4/4] sdhci: correct f_min in sd 3.0 > > Change-Id: Ie8604dbb5296b15da67071164564f21c60652b60 > > Signed-off-by: Zhangfei Gao > --- > drivers/mmc/host/sdhci.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index f980fb7..5346803 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1835,6 +1835,8 @@ int sdhci_add_host(struct sdhci_host *host) > mmc->ops = &sdhci_ops; > if (host->ops->get_min_clock) > mmc->f_min = host->ops->get_min_clock(host); > + else if (host->version >= SDHCI_SPEC_300) > + mmc->f_min = host->max_clk / 2046; > else > mmc->f_min = host->max_clk / 256; > mmc->f_max = host->max_clk; Has anyone else tested this change? Looks correct, but it would be nice to have a Tested-by or Acked-by on this. Thanks, -- Chris Ball One Laptop Per Child