Re: [patch] sdhci: correct f_min in sd 3.0

[Chris Ball <cjb@laptop.org>]

Hi,

On Mon, Sep 20, 2010 at 03:32:58AM -0400, zhangfei gao wrote:
> From: Zhangfei Gao <zhangfei.gao@marvell.com>
> Date: Mon, 20 Sep 2010 15:15:18 -0400
> Subject: [PATCH 4/4] sdhci: correct f_min in sd 3.0
> 
> Change-Id: Ie8604dbb5296b15da67071164564f21c60652b60
> 
> Signed-off-by: Zhangfei Gao <zhangfei.gao@marvell.com>
> ---
>  drivers/mmc/host/sdhci.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index f980fb7..5346803 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1835,6 +1835,8 @@ int sdhci_add_host(struct sdhci_host *host)
>  	mmc->ops = &sdhci_ops;
>  	if (host->ops->get_min_clock)
>  		mmc->f_min = host->ops->get_min_clock(host);
> +	else if (host->version >= SDHCI_SPEC_300)
> +		mmc->f_min = host->max_clk / 2046;
>  	else
>  		mmc->f_min = host->max_clk / 256;
>  	mmc->f_max = host->max_clk;

Oh, right -- it would be good to #define symbols for 256 and 2046,
since we're inserting them into sdhci.c for the second time.
Perhaps SDHCI_MAX_DIV_SPEC_{200,300}?

I can do that in a separate patch if you prefer, or you could roll
it into this one.

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child