From: Wolfram Sang <w.sang@pengutronix.de>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver
Date: Mon, 27 Sep 2010 12:37:22 +0200 [thread overview]
Message-ID: <20100927103722.GC2664@pengutronix.de> (raw)
In-Reply-To: <1285233266-5039-1-git-send-email-peppe.cavallaro@st.com>
[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]
On Thu, Sep 23, 2010 at 11:14:24AM +0200, Giuseppe CAVALLARO wrote:
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
I'd prefer it the way sdhci-mv.c is doing it (just one #if-block and
returning the code from the sdhci_*-functions). Then it should be fine.
> ---
> drivers/mmc/host/sdhci-pltfm.c | 22 ++++++++++++++++++++++
> 1 files changed, 22 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index e045e3c..89ea64b 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -165,6 +165,24 @@ static const struct platform_device_id sdhci_pltfm_ids[] = {
> };
> MODULE_DEVICE_TABLE(platform, sdhci_pltfm_ids);
>
> +#ifdef CONFIG_PM
> +static int sdhci_pltfm_suspend(struct platform_device *dev, pm_message_t pm)
> +{
> + struct sdhci_host *host = platform_get_drvdata(dev);
> +
> + sdhci_suspend_host(host, pm);
> + return 0;
> +}
> +
> +static int sdhci_pltfm_resume(struct platform_device *dev)
> +{
> + struct sdhci_host *host = platform_get_drvdata(dev);
> +
> + sdhci_resume_host(host);
> + return 0;
> +}
> +#endif
> +
> static struct platform_driver sdhci_pltfm_driver = {
> .driver = {
> .name = "sdhci",
> @@ -173,6 +191,10 @@ static struct platform_driver sdhci_pltfm_driver = {
> .probe = sdhci_pltfm_probe,
> .remove = __devexit_p(sdhci_pltfm_remove),
> .id_table = sdhci_pltfm_ids,
> +#ifdef CONFIG_PM
> + .suspend = sdhci_pltfm_suspend,
> + .resume = sdhci_pltfm_resume,
> +#endif
> };
>
> /*****************************************************************************\
> --
> 1.5.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-09-27 10:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 9:14 [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver Giuseppe CAVALLARO
2010-09-23 9:14 ` [PATCH (mmc-next) 2/3] mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d Giuseppe CAVALLARO
2010-09-23 9:14 ` [PATCH (mmc-next) 3/3] mmc: fix a warning when compile the sdhci d.d Giuseppe CAVALLARO
2010-09-27 10:54 ` Wolfram Sang
2010-09-27 12:57 ` Peppe CAVALLARO
2010-09-27 14:17 ` Wolfram Sang
2010-09-27 10:43 ` [PATCH (mmc-next) 2/3] mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d Wolfram Sang
2010-09-27 12:57 ` Peppe CAVALLARO
2010-09-27 14:13 ` Wolfram Sang
2010-09-27 14:20 ` Peppe CAVALLARO
2010-09-27 14:30 ` Wolfram Sang
2010-09-24 5:54 ` [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver Peppe CAVALLARO
2010-09-24 9:04 ` Wolfram Sang
2010-09-24 9:49 ` Peppe CAVALLARO
2010-09-27 10:37 ` Wolfram Sang [this message]
2010-09-27 12:57 ` Peppe CAVALLARO
2010-09-27 13:24 ` Peppe CAVALLARO
2010-09-27 14:15 ` Wolfram Sang
2010-09-27 14:25 ` Peppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927103722.GC2664@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-mmc@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox