linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-mmc@vger.kernel.org, zhangfei gao <zhangfei.gao@gmail.com>,
	Zhu Richard-R65037 <r65037@freescale.com>,
	Philip Rakity <prakity@marvell.com>
Subject: Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data
Date: Tue, 28 Sep 2010 16:57:58 +0400	[thread overview]
Message-ID: <20100928125758.GA32038@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1285677406-3359-2-git-send-email-w.sang@pengutronix.de>

On Tue, Sep 28, 2010 at 02:36:41PM +0200, Wolfram Sang wrote:
> We need to carry some information per host, e.g. the clock. Add a
> structure for it and initialize it in the generic part.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
[...]
> +++ b/drivers/mmc/host/sdhci-pltfm.h
> @@ -11,8 +11,14 @@
>  #ifndef _DRIVERS_MMC_SDHCI_PLTFM_H
>  #define _DRIVERS_MMC_SDHCI_PLTFM_H
>  
> +#include <linux/clk.h>
>  #include <linux/sdhci-pltfm.h>
>  
> +struct sdhci_pltfm_host {
> +	struct clk *clk;
> +	u32 scratchpad; /* to handle quirks across io-accessor calls */

#include <linux/types.h> for u32.

Otherwise, looks good.

Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2010-09-28 12:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28 12:36 [PATCH 0/6] Add driver for mx35/51-esdhc-controller (and update sdhci for that) Wolfram Sang
2010-09-28 12:36 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-09-28 12:57   ` Anton Vorontsov [this message]
2010-09-28 13:54   ` zhangfei gao
     [not found]   ` <48641052-49AF-4A24-9C8C-42E59791D6A7@marvell.com>
2010-09-28 14:49     ` Wolfram Sang
2010-09-28 12:36 ` [PATCH 2/6] mmc: sdhci-pltfm: move .h-file into apropriate subdir Wolfram Sang
2010-09-28 12:36 ` [PATCH 3/6] mmc: sdhci: introduce private get_ro Wolfram Sang
2010-09-28 12:36 ` [PATCH 4/6] mmc: sdhci_pltfm: pass platform_data on custom init-call Wolfram Sang
2010-09-28 12:58   ` Anton Vorontsov
2010-09-28 12:36 ` [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-09-28 12:58   ` Anton Vorontsov
2010-09-28 12:36 ` [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-09-28 12:58   ` Anton Vorontsov
2010-09-28 14:04   ` zhangfei gao
2010-09-28 14:51     ` Wolfram Sang
2010-09-28 20:57     ` Ben Dooks
2010-09-29  1:59       ` zhangfei gao
2010-09-29  2:27         ` Zhu Richard-R65037
2010-09-29  3:22           ` zhangfei gao
2010-09-29  3:41             ` Zhu Richard-R65037
2010-09-29 19:26       ` Wolfram Sang
  -- strict thread matches above, loose matches on Subject: below --
2010-09-29 20:07 [PATCH V3 0/6] SD/MMC-driver for MX35/51 (and improvements to SDHCI) Wolfram Sang
2010-09-29 20:07 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-09-29 21:24   ` Richard Röjfors
2010-09-30  8:16     ` Wolfram Sang
2010-09-30  9:54       ` Richard Röjfors
2010-09-30 10:19         ` Wolfram Sang
2010-09-30 11:09           ` Anton Vorontsov
2010-10-11 14:21 [PATCH 0/6] SD/MMC driver for MX25/35/51 Wolfram Sang
2010-10-11 14:21 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-10-15 10:20 [PATCH V5 0/6] SD/MMC driver for MX25/35/51 Wolfram Sang
2010-10-15 10:20 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100928125758.GA32038@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=prakity@marvell.com \
    --cc=r65037@freescale.com \
    --cc=w.sang@pengutronix.de \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).