From: Wolfram Sang <w.sang@pengutronix.de>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
eric.y.miao@gmail.com, Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [patch 1/3] sdhci-pltfm: add call back get_quirk
Date: Tue, 28 Sep 2010 21:39:56 +0200 [thread overview]
Message-ID: <20100928193956.GA11280@pengutronix.de> (raw)
In-Reply-To: <AANLkTik_UXUxESmzWCEBxCdME0E-GOpVYxTa=31Lc1-V@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
> > I might be blind, but I can't see why you can't handle that in init()?
>
> The issue is not init, but the common quirk in pdata.
> If using only one quirks in pdata combined with one driver, then
> different device would impact each other.
> for example device.0 set QUIRK_BROKEN_A to pdata->quirks, the device.1
> would use this quirk as default one, device.1 set QUIRK_BROKEN_B to
> pdata->quirks, then what device.2 default quirk would become
> QUIRK_DEFAULT | QUIRK_BROKEN_A | QUIRK_BROKEN_B.
>
> So differnet device should have quirk by iteslf, and pltfm.c would get
> such quirk after init.
Aren't devices .0, .1 and .2 own platform_devices and as such have
independent platform_data?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-09-28 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 2:57 [patch 1/3] sdhci-pltfm: add call back get_quirk zhangfei gao
2010-09-28 14:11 ` zhangfei gao
2010-09-28 14:20 ` Wolfram Sang
2010-09-28 15:23 ` zhangfei gao
2010-09-28 19:39 ` Wolfram Sang [this message]
2010-09-29 1:51 ` zhangfei gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928193956.GA11280@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=cjb@laptop.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox