Re: [patch 1/3] sdhci-pltfm: add call back get_quirk

zhangfei gao
2010-09-29T01:51:51Z

On Wed, Sep 29, 2010 at 3:39 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
>> > I might be blind, but I can't see why you can't handle that in init()?
>>
>> The issue is not init, but the common quirk in pdata.
>> If using only one quirks in pdata combined with one driver, then
>> different device would impact each other.
>> for example device.0 set QUIRK_BROKEN_A to pdata->quirks, the device.1
>> would use this quirk as default one, device.1 set QUIRK_BROKEN_B to
>> pdata->quirks, then what device.2 default quirk would become
>> QUIRK_DEFAULT | QUIRK_BROKEN_A | QUIRK_BROKEN_B.
>>
>> So differnet device should have quirk by iteslf, and pltfm.c would get
>> such quirk after init.
>
> Aren't devices .0, .1 and .2 own platform_devices and as such have
> independent platform_data?

Take sdhci_cns3xxx as example, only one sdhci_csn3xx_pdata with one .quirks
>
> --
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkyiRIwACgkQD27XaX1/VRuG/QCgqaP16S0vKezI4zgmuRAdxrd8
> IWkAoLAW0WgpbjiLlOH95a+M7B2fISNA
> =X72n
> -----END PGP SIGNATURE-----
>
>