Re: [patch 1/3] sdhci-pltfm: add call back get_quirk

Wolfram Sang
2010-09-28T19:39:59Z

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

> > I might be blind, but I can't see why you can't handle that in init()?
>
> The issue is not init, but the common quirk in pdata.
> If using only one quirks in pdata combined with one driver, then
> different device would impact each other.
> for example device.0 set QUIRK_BROKEN_A to pdata->quirks, the device.1
> would use this quirk as default one, device.1 set QUIRK_BROKEN_B to
> pdata->quirks, then what device.2 default quirk would become
> QUIRK_DEFAULT | QUIRK_BROKEN_A | QUIRK_BROKEN_B.
>
> So differnet device should have quirk by iteslf, and pltfm.c would get
> such quirk after init.

Aren't devices .0, .1 and .2 own platform_devices and as such have
independent platform_data?

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]