Re: [PATCH] sdio: fix suspend/resume regression

Maxim Levitsky
2010-10-22T00:25:14Z

On Thu, 2010-10-21 at 19:55 -0400, Nicolas Pitre wrote:
> On Fri, 22 Oct 2010, Maxim Levitsky wrote:
>
> > So what happens if you set .suspend to NULL? instead of -ENOSYS return?
>
> At run time, the driver may decide to handle the suspend request and
> return 0, or decide to simply return -ENOSYS if it doesn't want to
> bother with the suspend meaning that the card should be removed, or
> return another error code meaning that the suspend request must be
> aborted.

I am afraid that this is very hard to support.
If .suspend would be called from pm notifier, it would create problems
last time I checked.
Or maybe it won't?
I will test that again, as it might be very nice solution.
I could even just call the mmc_suspend_host from the pm notifier.

Best regards,
Maxim Levitsky