public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Philip Rakity <prakity@marvell.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] sdhci: sdhci_dumpregs: allow private information to be dumped on error
Date: Tue, 19 Oct 2010 21:04:45 +0100	[thread overview]
Message-ID: <20101019200445.GB28424@void.printf.net> (raw)
In-Reply-To: <20101019194724.GC31336@pengutronix.de>

Hi,

On Tue, Oct 19, 2010 at 09:47:24PM +0200, Wolfram Sang wrote:
> On Tue, Oct 19, 2010 at 11:27:22AM -0700, Philip Rakity wrote:
> > Our controller has private registers that are useful to see on error.
> > define a new host->ops to allow these registers to be printed
> > 
> > Signed-off-by: Philip Rakity <prakity@marvell.com>
> 
> I wonder if we really need such a thing in the mainline kernel? It is probably
> used for debugging the driver?

There's another question:  why merge a patch that adds a hook that isn't
used by anything currently in the kernel?  Should we wait until this is
accompanied by a print_private_info() implementation in a mainline
driver, rather than adding it proactively?

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2010-10-19 20:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 18:27 [PATCH] sdhci: sdhci_dumpregs: allow private information to be dumped on error Philip Rakity
2010-10-19 19:47 ` Wolfram Sang
2010-10-19 20:04   ` Chris Ball [this message]
2010-10-19 21:47     ` Philip Rakity
2010-10-20 11:16       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101019200445.GB28424@void.printf.net \
    --to=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=prakity@marvell.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox