From: Wolfram Sang <w.sang@pengutronix.de>
To: Philip Rakity <prakity@marvell.com>
Cc: Chris Ball <cjb@laptop.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] sdhci: sdhci_dumpregs: allow private information to be dumped on error
Date: Wed, 20 Oct 2010 13:16:21 +0200 [thread overview]
Message-ID: <20101020111621.GA10261@pengutronix.de> (raw)
In-Reply-To: <16B90FE9-6FB8-4FCA-867E-CE40EBF26223@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
Hi Philip,
> sdhci_dumpregs is used to debug the hardware/driver so I do not see an issue
> here. The register info is not useful to a normal linux user. We can fine
> tune the timing on the controller so knowing the settings is useful if there
> are CRC errors.
I'd prefer to keep such changes local because they are not needed for a wider
audience. (And adding something to dump_regs is trivial enough.)
Nevertheless, thanks for the suggestion!
Best regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2010-10-20 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 18:27 [PATCH] sdhci: sdhci_dumpregs: allow private information to be dumped on error Philip Rakity
2010-10-19 19:47 ` Wolfram Sang
2010-10-19 20:04 ` Chris Ball
2010-10-19 21:47 ` Philip Rakity
2010-10-20 11:16 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020111621.GA10261@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox