From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver Date: Thu, 21 Oct 2010 15:52:49 +0100 Message-ID: <20101021145249.GA13095@void.printf.net> References: <20101021141302.GA11912@void.printf.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20101021141302.GA11912@void.printf.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: zhangfei gao Cc: Matt Fleming , eric.y.miao@gmail.com, linux-mmc@vger.kernel.org, Wolfram Sang , Haojian Zhuang , linux-arm-kernel@lists.infradead.org List-Id: linux-mmc@vger.kernel.org Hi, On Thu, Oct 21, 2010 at 03:13:02PM +0100, Chris Ball wrote: > On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: > > Update with comments from Matt and Eric. > > Test with sd and emmc. > > > > >From e5dd554ed4d3488a83d9a4888d68d1d85482f747 Mon Sep 17 00:00:00 2001 > > From: Zhangfei Gao > > Date: Mon, 20 Sep 2010 10:51:28 -0400 > > Subject: [PATCH] mmc: add support of sdhci-pxa driver > > > > Support Marvell PXA168/PXA910/MMP2 SD Host Controller > > > > Signed-off-by: Zhangfei Gao > > --- > > arch/arm/plat-pxa/include/plat/sdhci.h | 32 ++++ > > drivers/mmc/host/Kconfig | 12 ++ > > drivers/mmc/host/Makefile | 1 + > > drivers/mmc/host/sdhci-pxa.c | 259 ++++++++++++++++++++++++++++++++ > > 4 files changed, 304 insertions(+), 0 deletions(-) > > create mode 100644 arch/arm/plat-pxa/include/plat/sdhci.h > > create mode 100644 drivers/mmc/host/sdhci-pxa.c > > I'll take the drivers/mmc/ hunks, but you should send the plat-pxa/ > patch through the ARM tree. Oh. If we do that then the driver won't compile until everything's together, because it #includes . Haojian/Eric, what do you prefer here? Should I take the arch/arm/ hunk via the MMC tree? (If so, please provide ACKs.) Thanks, -- Chris Ball One Laptop Per Child