From: Anton Vorontsov <cbouatmailru@gmail.com>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: linux-mmc@vger.kernel.org, Xiaobo Xie <X.Xie@freescale.com>,
Chris Ball <cjb@laptop.org>, Kyungmin Park <kmpark@infradead.org>,
Philip Rakity <prakity@marvell.com>,
Pierre Ossman <pierre@ossman.eu>
Subject: Re: [patch] sdhci: remove SDHCI_QUIRK_FORCE_1_BIT_DATA
Date: Tue, 9 Nov 2010 15:27:39 +0300 [thread overview]
Message-ID: <20101109122739.GA6776@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <AANLkTimBGorfWHVCnVtUWx6n-22anXmQnKFXVGzB6TUf@mail.gmail.com>
Hi,
On Tue, Nov 09, 2010 at 06:37:58AM -0500, zhangfei gao wrote:
> Here is patch to remove SDHCI_QUIRK_FORCE_1_BIT_DATA, which only used
> in drivers/mmc/host/sdhci-of-core.c.
> The reason is quirk is too valuable resource, the type is u32, while
> the highest is (1<<29) now.
FYI, initially that wasn't a quirk. Here is Pierre's last opinion on that:
http://lists.ozlabs.org/pipermail/devicetree-discuss/2009-June/000981.html
Thanks,
> 1. MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA is opened by default in sdhci.c
> 2. platform driver could close such flag after sdhci_add_host.
>
> We have verified on our platform, would you mind check whether it
> impact your driver behavior.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-11-09 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 11:37 [patch] sdhci: remove SDHCI_QUIRK_FORCE_1_BIT_DATA zhangfei gao
2010-11-09 12:27 ` Anton Vorontsov [this message]
2010-11-09 12:31 ` Philip Rakity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109122739.GA6776@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=X.Xie@freescale.com \
--cc=cjb@laptop.org \
--cc=kmpark@infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pierre@ossman.eu \
--cc=prakity@marvell.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox