From: Simon Horman <horms@verge.net.au>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linux-mmc@vger.kernel.org,
Yusuke Goda <yusuke.goda.sx@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH v2] mmc, sh: Move constants to sh_mmcif.h
Date: Wed, 10 Nov 2010 19:21:09 +0900 [thread overview]
Message-ID: <20101110102109.GA12194@verge.net.au> (raw)
In-Reply-To: <20101110093223.GA369@linux-sh.org>
On Wed, Nov 10, 2010 at 06:32:23PM +0900, Paul Mundt wrote:
> On Tue, Nov 09, 2010 at 05:47:02PM +0900, Simon Horman wrote:
> > This moves some constants from sh_mmcif.c to sh_mmcif.h
> > so that they can be used in sh_mmcif_boot_init().
> >
> > It also alters the definition of SOFT_RST_OFF from (0 << 31) to
> > ~SOFT_RST_ON (= ~(1 << 31)). The former seems bogus. The latter is
> > consistent with the code in sh_mmcif_boot_init().
> >
> > Cc: Yusuke Goda <yusuke.goda.sx@renesas.com>
> > Cc: Magnus Damm <magnus.damm@gmail.com>
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> > ---
> > drivers/mmc/host/sh_mmcif.c | 23 -----------------------
> > include/linux/mmc/sh_mmcif.h | 39 ++++++++++++++++++++++++++++++++++-----
> > 2 files changed, 34 insertions(+), 28 deletions(-)
> >
> As this doesn't appear to introduce any bugfixes or functionality changes
> I've queued it with the .38 changes. Its on its own topic branch for now,
> but let me know if you have a dependency on this in future patches aimed
> at the merge window and I'll make sure it ends up merged wherever its
> needed.
>
Thanks, at this stage I don't expect any such dependencies.
I'll let you know if that situation changes.
prev parent reply other threads:[~2010-11-10 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 8:47 [PATCH v2] mmc, sh: Move constants to sh_mmcif.h Simon Horman
2010-11-10 9:32 ` Paul Mundt
2010-11-10 10:21 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110102109.GA12194@verge.net.au \
--to=horms@verge.net.au \
--cc=cjb@laptop.org \
--cc=lethal@linux-sh.org \
--cc=linux-mmc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yusuke.goda.sx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox