From: Sascha Hauer <s.hauer@pengutronix.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 4/4] [ARM] mxcmmc: remove a unnecessary release_resource() call
Date: Thu, 25 Nov 2010 10:03:11 +0100 [thread overview]
Message-ID: <20101125090311.GP6017@pengutronix.de> (raw)
In-Reply-To: <1290415671.5471.13.camel@mola>
On Mon, Nov 22, 2010 at 04:47:51PM +0800, Axel Lin wrote:
> Remove release_resource() after release_mem_region().
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mmc/host/mxcmmc.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
> index 2b9f7c8..4428594 100644
> --- a/drivers/mmc/host/mxcmmc.c
> +++ b/drivers/mmc/host/mxcmmc.c
> @@ -967,7 +967,6 @@ static int mxcmci_remove(struct platform_device *pdev)
> clk_put(host->clk);
>
> release_mem_region(host->res->start, resource_size(host->res));
> - release_resource(host->res);
>
> mmc_free_host(mmc);
>
> --
> 1.7.2
>
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2010-11-25 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 8:42 [PATCH 0/4] fix a memory leak related to request_mem_region/release_mem_region usage Axel Lin
2010-11-22 8:44 ` [PATCH 1/4] [ARM] davinci_mmc: fix a memory leak Axel Lin
2010-11-22 8:45 ` [PATCH 2/4] [ARM] mvsdio: " Axel Lin
2010-11-22 8:46 ` [PATCH 3/4] [ARM] pxamci: " Axel Lin
2010-11-22 8:47 ` [PATCH 4/4] [ARM] mxcmmc: remove a unnecessary release_resource() call Axel Lin
2010-11-25 9:03 ` Sascha Hauer [this message]
2010-12-05 2:51 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125090311.GP6017@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox