From: Chris Ball <cjb@laptop.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 4/4] [ARM] mxcmmc: remove a unnecessary release_resource() call
Date: Sun, 5 Dec 2010 02:51:51 +0000 [thread overview]
Message-ID: <20101205025150.GA24000@void.printf.net> (raw)
In-Reply-To: <20101125090311.GP6017@pengutronix.de>
Hi,
On Thu, Nov 25, 2010 at 10:03:11AM +0100, Sascha Hauer wrote:
> On Mon, Nov 22, 2010 at 04:47:51PM +0800, Axel Lin wrote:
> > Remove release_resource() after release_mem_region().
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> > ---
> > drivers/mmc/host/mxcmmc.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
> > index 2b9f7c8..4428594 100644
> > --- a/drivers/mmc/host/mxcmmc.c
> > +++ b/drivers/mmc/host/mxcmmc.c
> > @@ -967,7 +967,6 @@ static int mxcmci_remove(struct platform_device *pdev)
> > clk_put(host->clk);
> >
> > release_mem_region(host->res->start, resource_size(host->res));
> > - release_resource(host->res);
> >
> > mmc_free_host(mmc);
> >
Pushed to mmc-next for .38, thanks.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2010-12-05 2:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 8:42 [PATCH 0/4] fix a memory leak related to request_mem_region/release_mem_region usage Axel Lin
2010-11-22 8:44 ` [PATCH 1/4] [ARM] davinci_mmc: fix a memory leak Axel Lin
2010-11-22 8:45 ` [PATCH 2/4] [ARM] mvsdio: " Axel Lin
2010-11-22 8:46 ` [PATCH 3/4] [ARM] pxamci: " Axel Lin
2010-11-22 8:47 ` [PATCH 4/4] [ARM] mxcmmc: remove a unnecessary release_resource() call Axel Lin
2010-11-25 9:03 ` Sascha Hauer
2010-12-05 2:51 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101205025150.GA24000@void.printf.net \
--to=cjb@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox