From: Chris Ball <cjb@laptop.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Aries Lee <arieslee@jmicron.com>,
Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH v2] mmc: Add support for JMicron 388 SD/MMC controller
Date: Thu, 9 Dec 2010 01:38:43 +0000 [thread overview]
Message-ID: <20101209013843.GA19741@void.printf.net> (raw)
In-Reply-To: <s5h7hfk3aap.wl%tiwai@suse.de>
Hi Takashi,
On Wed, Dec 08, 2010 at 10:04:30AM +0100, Takashi Iwai wrote:
> JMicron 388 SD/MMC combo controller supports the 1.8V low-voltage for
> SD, but MMC doesn't work with the low-voltage, resulting in an error
> at probing.
>
> This patch adds the support for multiple voltage mask per device type,
> so that SD works with 1.8V while MMC forces 3.3V. Here new ocr_avail_*
> fields for each device are introduced, so that the actual OCR mask is
> switched dynamically.
>
> Also, the restriction of low-voltage in core/sd.c is removed when the
> bit is allowed explicitly via ocr_avail_sd mask.
>
> This patch was rewritten from scratch based on Aries' original code.
>
> Signed-off-by: Aries Lee <arieslee@jmicron.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Looks good, pushed to mmc-next for .38. Thanks!
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-12-09 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 9:04 [PATCH v2] mmc: Add support for JMicron 388 SD/MMC controller Takashi Iwai
2010-12-09 1:38 ` Chris Ball [this message]
2010-12-09 2:18 ` zhangfei gao
2010-12-09 8:15 ` Takashi Iwai
2010-12-09 8:59 ` Aries Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209013843.GA19741@void.printf.net \
--to=cjb@laptop.org \
--cc=arieslee@jmicron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox