Re: [PATCH v4] dw_mmc: Add Synopsys DesignWare mmc host driver.

Will Newton
2011-02-08T12:06:59Z

On Tue, Feb 8, 2011 at 10:49 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi Will
>
> I'm probing dw_mmc on Samsung SoC...
>
> So i have some board specific data..
>
> But i didn't want to add board specific data in dw_mmc.c
> I want to use get_cd()/get_wd()/init()...So i asked to you..:)

It may be possible to use your board specific data in your callbacks
directly rather than passing the board data to the driver and passing
it back, although it depends on the structure of your code.

> If i need not the data information, i will not append them..
> you're right, maybe "struct dw_mci" need not..(just example)
>
> And i think that need card_detect irq-handler function..if we use pdata->init..isn't? :)

I think the use of pdata->init should be made optional, as it doesn't
seem to be needed on most SoCs.

> In future, if i need your help, can i ask to you?

Yes, certainly. We continue to work on the driver and would be happy
to have our bugs fixed! ;-)

> Onemore...Did you test the dw_mmc..?
> If you can answer, i want to know the performance..

We have tested it, unfortunately I don't have any accurate performance
figures to hand. The perform seems to be in the expected range though.