From: Olof Johansson <olof@lixom.net>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org,
Yvonne Yip <y@palm.com>, Gary King <gking@nvidia.com>,
Todd Poynor <toddpoynor@google.com>,
Dmitry Shmidt <dimitrysh@google.com>,
Rhyland Klein <rklein@nvidia.com>
Subject: Re: [PATCH 4/4] mmc: add sdhci-tegra driver for Tegra SoCs
Date: Wed, 15 Dec 2010 02:46:34 -0600 [thread overview]
Message-ID: <20101215084634.GB29717@lixom.net> (raw)
In-Reply-To: <20101215084307.GA29717@lixom.net>
On Wed, Dec 15, 2010 at 02:43:07AM -0600, Olof Johansson wrote:
> Hi,
>
> On Wed, Dec 15, 2010 at 09:35:46AM +0100, Wolfram Sang wrote:
>
> > Can't you just use sdhci-pltfm?
>
> Not if I want to hide some of the SoC-specific errata with driver-local
> workarounds instead of polluting the global quirk namespace with them.
>
> Otherwise, yeah, it'd be a good candidate for it.
Hm, on second look, it seems as if the -pltfm can take the ops structure
from the platform data.
Still, I don't see the point -- the amount of code would be about the
same between wrapping it with a coat of workarounds and op structures,
gpio setup, etc, and just doing a separate simple driver. The code shared
is really just the resource allocation pieces.
-Olof
next prev parent reply other threads:[~2010-12-15 8:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 4:49 [PATCH 0/4] Add SDHCI driver for Tegra Olof Johansson
2010-12-15 4:49 ` [PATCH 1/4] sdhci: add quirk for max len ADMA descriptors Olof Johansson
2010-12-15 4:49 ` [PATCH 2/4] sdhci: add quirk for broken sdio irq Olof Johansson
2010-12-15 10:42 ` zhangfei gao
2010-12-15 10:54 ` Olof Johansson
2010-12-15 11:03 ` Wolfram Sang
2010-12-15 11:24 ` Olof Johansson
2010-12-15 11:44 ` Wolfram Sang
2010-12-15 10:57 ` Wolfram Sang
2010-12-15 11:34 ` Olof Johansson
2010-12-15 4:49 ` [PATCH 3/4] sdhci: don't finish commands in flight Olof Johansson
2010-12-15 4:49 ` [PATCH 4/4] mmc: add sdhci-tegra driver for Tegra SoCs Olof Johansson
2010-12-15 8:35 ` Wolfram Sang
2010-12-15 8:43 ` Olof Johansson
2010-12-15 8:46 ` Olof Johansson [this message]
2010-12-15 10:37 ` Wolfram Sang
2010-12-15 11:40 ` Olof Johansson
2010-12-15 11:59 ` Wolfram Sang
2010-12-15 13:03 ` Olof Johansson
2010-12-15 13:40 ` Wolfram Sang
2010-12-15 11:23 ` Mike Rapoport
2010-12-15 11:31 ` Olof Johansson
2010-12-15 11:33 ` Pavan Kondeti
2010-12-15 11:35 ` Olof Johansson
2010-12-15 11:37 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215084634.GB29717@lixom.net \
--to=olof@lixom.net \
--cc=cjb@laptop.org \
--cc=dimitrysh@google.com \
--cc=gking@nvidia.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=toddpoynor@google.com \
--cc=w.sang@pengutronix.de \
--cc=y@palm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox