Re: [PATCH 2/4] sdhci: add quirk for broken sdio irq

[Olof Johansson <olof@lixom.net>]

On Wed, Dec 15, 2010 at 12:03:12PM +0100, Wolfram Sang wrote:
> 
> > > Really appreciate if not using the valuable quirk resource, which is u32.
> > 
> > No big deal. Next person that needs a quirk bit gets to bump the data
> > type to u64.
> 
> That won't scale for long, I fear (and will make sdhci.c an unreadable
> mess). We need less quirks and more flexible means to handle flawed
> controllers, I'd think.

It won't scale for long, but it'll give a buffer while a cleaned up
quirk structure can be hashed out and implemented.

There are already a handful of quirks in there that can be trivially
moved into their respective drivers by overriding the register read/write
functions (like I already have for a couple on sdhci-tegra). Some of
the others are not obvious to me how they can be easily abstracted out
without adding even more callbacks up and down the stack for adding hooks.


-Olof