Re: [PATCH 2/4] sdhci: add quirk for broken sdio irq

[Wolfram Sang <w.sang@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]


> > That won't scale for long, I fear (and will make sdhci.c an unreadable
> > mess). We need less quirks and more flexible means to handle flawed
> > controllers, I'd think.
> 
> It won't scale for long, but it'll give a buffer while a cleaned up
> quirk structure can be hashed out and implemented.

I am a bit pessimistic here; at the end of u64, the first suggestion
will probably be using two u64 ;)

> There are already a handful of quirks in there that can be trivially
> moved into their respective drivers by overriding the register read/write
> functions (like I already have for a couple on sdhci-tegra). Some of

I know. Despite being easy, it hardly resulted in patches so far.

> the others are not obvious to me how they can be easily abstracted out
> without adding even more callbacks up and down the stack for adding hooks.

Yes, it needs some architectural work. If we'd go for u64 now, we will
just earn more quirks and it will get harder and harder to abstract.

Kind regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]