From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 4/4] mmc: add sdhci-tegra driver for Tegra SoCs Date: Wed, 15 Dec 2010 12:59:11 +0100 Message-ID: <20101215115911.GH3515@pengutronix.de> References: <1292388576-25600-1-git-send-email-olof@lixom.net> <1292388576-25600-5-git-send-email-olof@lixom.net> <20101215083546.GA16459@pengutronix.de> <20101215084307.GA29717@lixom.net> <20101215084634.GB29717@lixom.net> <20101215103730.GB3515@pengutronix.de> <20101215114000.GC2500@lixom.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CNfT9TXqV7nd4cfk" Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:47720 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752619Ab0LOL7P (ORCPT ); Wed, 15 Dec 2010 06:59:15 -0500 Content-Disposition: inline In-Reply-To: <20101215114000.GC2500@lixom.net> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Olof Johansson Cc: Chris Ball , linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org, Yvonne Yip , Gary King , Todd Poynor , Dmitry Shmidt , Rhyland Klein --CNfT9TXqV7nd4cfk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > If there is something yet missing in sdhci-pltfm which you need, it > > probably is worth adding it there. Chances are good that other > > pltfm-users might want that, too. >=20 > Taking that to an extreme, any sdhci driver should plug into sdhci-pltfm = and > just add the hooks needed. It will result in just one more abstraction la= yer that > makes following code flow harder. Yes, of course. SDHCI is pretty well defined, so a good core on a SOC should just need sdhci-pltfm and some pltfm-data (and we got rid of a complete driver that way recently). If the core has quirks (as most sadly do), a bit of extension is needed. I'd prefer to have those extensions in one place rather than hidden in various drivers. I have the assumption they will be reusable, maybe this is a core point where we disagree? > Especially if you want some of the quirk code to be moved from sdhci.c > to the driver. Please elaborate. Why is sdhci-pltfm complicating things here? Kind regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --CNfT9TXqV7nd4cfk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk0IrY8ACgkQD27XaX1/VRvsRACaA4eb2ReSUqAqD3ocS5pR9e/M k1IAnRe7iFosZBYn78X8V7mDQ53I95Ie =7nRi -----END PGP SIGNATURE----- --CNfT9TXqV7nd4cfk--